Skip to content

Fix connection pool key collision #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix connection pool key collision #74

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1bdbf0
Fix connection pool key collision
bufke Nov 13, 2025
55b43c4
Add more config values to key
bufke Nov 15, 2025
7e77e7b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion django_valkey/base_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,14 @@ def get_or_create_connection_pool(self, params: dict) -> Pool | Any:
Reimplement this method if you want distinct
connection pool instance caching behavior.
"""
key: str = params["url"]
# Serialize params/options into stable strings. Using str()
# robustly handles unhashable values like dicts.
params_key = "::".join(f"{k}={str(v)}" for k, v in sorted(params.items()))
options_key = "::".join(
f"{k}={str(v)}" for k, v in sorted(self.options.items())
)
key = (params_key, options_key)

if key not in self._pools:
self._pools[key] = self.get_connection_pool(params)
return self._pools[key]
Expand Down