-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Update committees urls #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update committees urls #2308
Conversation
sarahboyce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I have a few nit picks
Note that the code of conduct committee is now the code of conduct working group and I think it makes sense to update the team naming throughout the site 👍
| <ul class="list-links"> | ||
| <li><a href="{% url 'code_of_conduct' %}">{% translate "Code of Conduct" %}</a></li> | ||
| <li><a href="/foundation/committees/#conduct">{% translate "Committee" %}</a></li> | ||
| <li><a href="{% url 'members:teams' %}#code-of-conduct-team">{% translate "Committee" %}</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <li><a href="{% url 'members:teams' %}#code-of-conduct-team">{% translate "Committee" %}</a></li> | |
| <li><a href="{% url 'members:teams' %}#code-of-conduct-team">{% translate "Code of Conduct working group" %}</a></li> |
| {% with coc_teams_url=teams_url|add:'#code-of-conduct-team' %} | ||
| <p> | ||
| {% blocktranslate trimmed %} | ||
| All responses to reports of conduct violations will be managed by a | ||
| <a href="{{ coc_teams_url }}">Code of Conduct Committee</a> ("the committee"). | ||
| {% endblocktranslate %}</p> | ||
| {% endwith %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {% with coc_teams_url=teams_url|add:'#code-of-conduct-team' %} | |
| <p> | |
| {% blocktranslate trimmed %} | |
| All responses to reports of conduct violations will be managed by a | |
| <a href="{{ coc_teams_url }}">Code of Conduct Committee</a> ("the committee"). | |
| {% endblocktranslate %}</p> | |
| {% endwith %} | |
| <p> | |
| {% blocktranslate trimmed %} | |
| All responses to reports of conduct violations will be managed by the | |
| <a href="{{ teams_url }}#code-of-conduct-team">Code of Conduct working group</a>. | |
| {% endblocktranslate %}</p> |
Personally I wouldn't bother with the use of add and save an indent/extra logic here
| {% with coc_teams_url=teams_url|add:'#code-of-conduct-team' %} | ||
| <p> | ||
| {% blocktranslate trimmed %} | ||
| In that case, you can make a report directly to any or all of the current | ||
| (vice/co) chairs of the Code of Conduct committee. Their e-mail addresses are | ||
| listed on the <a href="{{ coc_teams_url }}">Code of Conduct Committee</a> | ||
| page. The chairs will follow the usual enforcement process with the other | ||
| members, but will exclude the member(s) that the report concerns from any | ||
| discussion or decision making.{% endblocktranslate %}</p> | ||
| {% endwith %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {% with coc_teams_url=teams_url|add:'#code-of-conduct-team' %} | |
| <p> | |
| {% blocktranslate trimmed %} | |
| In that case, you can make a report directly to any or all of the current | |
| (vice/co) chairs of the Code of Conduct committee. Their e-mail addresses are | |
| listed on the <a href="{{ coc_teams_url }}">Code of Conduct Committee</a> | |
| page. The chairs will follow the usual enforcement process with the other | |
| members, but will exclude the member(s) that the report concerns from any | |
| discussion or decision making.{% endblocktranslate %}</p> | |
| {% endwith %} | |
| <p> | |
| {% blocktranslate trimmed %} | |
| In that case, you can make a report directly to any or all of the current | |
| (vice/co) chairs of the Code of Conduct working group. Their e-mail addresses are | |
| listed on the <a href="{{ teams_url }}#code-of-conduct-team">Code of Conduct working group</a> | |
| page. The chairs will follow the usual enforcement process with the other | |
| members, but will exclude the member(s) that the report concerns from any | |
| discussion or decision making.{% endblocktranslate %}</p> |
Their e-mail addresses are listed on the...
This is actually not true of the teams page. Is this still true that this is a way to report? (cc @jefftriplett )
| msgid "" | ||
| "All responses to reports of conduct violations will be managed by a <a " | ||
| "href=\"/foundation/committees/\">Code of Conduct Committee</a> (\"the " | ||
| "href=\"{coc_teams_url}\">Code of Conduct Committee</a> (\"the " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like more translation file updates are required, however, I don't think we use the translations on the website so I'm not sure we are keeping this up-to-date (maybe @marksweb can clarify here?)
Related to issue #2257
Replaced hardcoded committees URL with variable to teams page URL (anchored to the CoC team).