Skip to content

Conversation

@denizzzka
Copy link

@denizzzka denizzzka commented Sep 17, 2025

Adds a link to the source, without editing enabled. I am found that it is very convenient to have link here.

(Yes, I know there's usually a link to the source at the bottom of the page)

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@denizzzka denizzzka marked this pull request as draft September 17, 2025 12:52
@denizzzka denizzzka marked this pull request as ready for review September 17, 2025 13:29
@denizzzka denizzzka changed the title Adds link to source code of current module Adds a link to the source code of the current module Sep 17, 2025
Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this link is already there?

image

Or does the old link exist only on some pages?

However, I can plainly see the code for the existing link just 10 lines above the added code, so I'm not sure what this addition brings.

@denizzzka
Copy link
Author

https://dlang.org/phobos/std_algorithm.html

There's a link to the source at the bottom and to edit at the top. I think it's convient to have a link to the source at the top, too.

This from my personal experience: I realized that every time I see a link to edit, I try to find a link to the source, but I can't find it at the top and I click edit, and then return to see the source itself.

@CyberShadow
Copy link
Member

I see. Then, you have added this to the wrong place - the current patch is for the DDox layout (https://dlang.org/library/std/algorithm.html), which already has this link; you probably want to edit dlang.org.ddoc or something adjacent instead.

@denizzzka
Copy link
Author

Ok (I'm too lazy to deal with this))

@denizzzka denizzzka closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants