Run tests with MongoDB ODM using native laxy objects, fix other deprecations #3003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
commented
Oct 29, 2025
| static::assertStringStartsWith('Proxy', get_class($test)); | ||
|
|
||
| /** @phpstan-ignore-next-line function.alreadyNarrowedType */ | ||
| if (method_exists($this->dm, 'isUninitializedObject')) { |
Contributor
Author
There was a problem hiding this comment.
This doesn't exist in the lowest supported ODM version
mbabker
commented
Oct 29, 2025
Comment on lines
+50
to
+53
| // Ignore unfixable deprecations | ||
| Deprecation::ignoreDeprecations( | ||
| 'https://github.com/doctrine-extensions/DoctrineExtensions/pull/2772', // Ignore annotations deprecations from self | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This is useful if you're running with <env name="DOCTRINE_DEPRECATIONS" value="trigger"/> in a custom phpunit.xml to see more of the triggered deprecations
mbabker
commented
Oct 29, 2025
| "doctrine/common": "^2.13 || ^3.0", | ||
| "doctrine/dbal": "^3.7 || ^4.0", | ||
| "doctrine/doctrine-bundle": "^2.3", | ||
| "doctrine/doctrine-bundle": "^2.3 || ^3.0", |
Contributor
Author
There was a problem hiding this comment.
Allows testing with the new major (nothing changed here for this package anyway)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
==========================================
+ Coverage 78.56% 78.74% +0.17%
==========================================
Files 169 169
Lines 8803 8689 -114
==========================================
- Hits 6916 6842 -74
+ Misses 1887 1847 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As advertised