Skip to content

Conversation

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Nov 14, 2025

Q A
Type improvement
BC Break no
Fixed issues -

Summary

The proxy dir is not used when native lazy objects are used. Trigger the deprecation only when it's enabled.

@GromNaN GromNaN added this to the 2.16.0 milestone Nov 14, 2025
@GromNaN GromNaN changed the base branch from 2.15.x to 2.16.x November 14, 2025 21:30
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be mentioned in the upgrade guide, and I think the annotations are not OK since the deprecation is conditional

@alcaeus
Copy link
Member

alcaeus commented Nov 18, 2025

This should be mentioned in the upgrade guide, and I think the annotations are not OK since the deprecation is conditional

I think the annotations are fine, since we'll be removing the methods along with all non-native proxies in 3.0.

@GromNaN GromNaN force-pushed the deprecate-proxy-dir branch from 2d31d34 to b8573b5 Compare November 18, 2025 18:29
@GromNaN GromNaN force-pushed the deprecate-proxy-dir branch from b8573b5 to 9f7b7b4 Compare November 18, 2025 19:02
@GromNaN
Copy link
Member Author

GromNaN commented Nov 18, 2025

This should be mentioned in the upgrade guide,

I added the upgrade instructions.

and I think the annotations are not OK since the deprecation is conditional

Calling this methods is actually deprecated. I could also mark them as @internal because we still need to use them internally. But we are going to remove them in 3.0. #2914

I don't want to have to keep this methods in 3.0 because we can't deprecate them in 2.x.

@greg0ire
Copy link
Member

Calling this methods is actually deprecated.

Oh OK great then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants