[BC break] Move doctrine/cache to optional dependencies
#2912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
doctrine/cacheis deprecated and archived.Motivation for introducing a breaking change:
doctrine/mongodb-odmwith composer, you get a message even ifdoctrine/cacheis not actively used.This is a breaking change only when calling
Configuration::getMetadataCacheImpl(). The workaround is easy: adddoctrine/cacheas project dependency.I consider projects that use
doctrine/cachedirectly without explicitly requiring the package to be in error.That's why I'm adding a conflict with
doctrine/mongodb-odm-bundle < 5, which did not have an explicit dependency but used theDoctrine\Common\Cacheclasses:https://github.com/doctrine/DoctrineMongoDBBundle/blob/48c29009c24ff74c47782c0c9c2736f1f5fd9b0e/DependencyInjection/DoctrineMongoDBExtension.php#L14-L15