Skip to content

Move hoistOutOfScopeFilters rule to DefaultRules #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2025
Merged

Move hoistOutOfScopeFilters rule to DefaultRules #3300

merged 3 commits into from
Nov 11, 2025

Conversation

@angelamayxie
Copy link
Contributor

@angelamayxie angelamayxie commented Nov 11, 2025 •
edited
Loading

fixes dolthub/dolt#10064

hoistOutOfScopeFilters was not running as part of finalizeUnions, causing us to not correctly analyze queries that were parts of unions

@angelamayxie angelamayxie marked this pull request as ready for review November 11, 2025 21:40
@angelamayxie angelamayxie requested a review from jycor November 11, 2025 21:40
jycor
jycor approved these changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelamayxie angelamayxie merged commit 83d2fda into main Nov 11, 2025
8 checks passed
@angelamayxie angelamayxie deleted the angela/finalizeunions_rules branch November 11, 2025 21:44
@BrewTestBot BrewTestBot mentioned this pull request Nov 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jycor jycor jycor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected UNION ALL Result of INNER JOIN and ANTI JOIN

3 participants

@angelamayxie @jycor