Skip to content

Fix Redpanda global config compatibility #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Redpanda global config compatibility #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/kotlin/dev/domnikl/schemaregistrygitops/SchemaRegistryClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ class SchemaRegistryClient(private val client: CachedSchemaRegistryClient) {
}

fun globalCompatibility(): Compatibility {
return Compatibility.valueOf(client.getCompatibility(""))
return Compatibility.valueOf(client.getCompatibility(null))
}

fun normalize(): Boolean {
return client.getConfig("").isNormalize ?: false
return client.getConfig(null).isNormalize ?: false
}

fun updateGlobalCompatibility(compatibility: Compatibility): Compatibility {
return Compatibility.valueOf(client.updateCompatibility("", compatibility.toString()))
return Compatibility.valueOf(client.updateCompatibility(null, compatibility.toString()))
}

fun updateNormalize(normalize: Boolean) {
val config = client.getConfig("")
val config = client.getConfig(null)
config.isNormalize = normalize
client.updateConfig("", config)
client.updateConfig(null, config)
}

fun compatibility(subject: String): Compatibility {
Expand Down
4 changes: 2 additions & 2 deletions src/test/kotlin/dev/domnikl/schemaregistrygitops/SchemaRegistryClientTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ class SchemaRegistryClientTest {

@Test
fun `can get global compatibility`() {
every { client.getCompatibility("") } returns "BACKWARD"
every { client.getCompatibility(null) } returns "BACKWARD"

assertEquals(Compatibility.BACKWARD, wrapper.globalCompatibility())
}

@Test
fun `can update global compatibility`() {
every { client.updateCompatibility("", "FULL") } returns "FULL"
every { client.updateCompatibility(null, "FULL") } returns "FULL"

assertEquals(
Compatibility.FULL,
Expand Down