Skip to content

Issue #1024: Calculate baseline by the fastest benchmark #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Issue #1024: Calculate baseline by the fastest benchmark #2171

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
deedc64
Issue #1024: Calculate baseline by the fastest benchmark
Serg046 Oct 26, 2022
fd9f34f
Issue #1024: Add validations
Serg046 Oct 26, 2022
d20c117
Issue #1024: Correct configuration
Serg046 Oct 30, 2022
d8d99e2
Issue #1024: Make AutomaticBaselineSelectionIsCorrect test stable enough
Serg046 Oct 31, 2022
873243d
Update src/BenchmarkDotNet/Reports/Summary.cs
Serg046 Oct 31, 2022
885bc04
Fix a typo
Serg046 Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/BenchmarkDotNet/Configs/ManualConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,10 @@ public void Add(IConfig config)
columnHidingRules.AddRange(config.GetColumnHidingRules());
Options |= config.Options;
BuildTimeout = GetBuildTimeout(BuildTimeout, config.BuildTimeout);
AutomaticBaselineMode = config.AutomaticBaselineMode;
if (config.AutomaticBaselineMode != AutomaticBaselineMode.None)
{
AutomaticBaselineMode = config.AutomaticBaselineMode;
}
}

/// <summary>
Expand Down
3 changes: 2 additions & 1 deletion src/BenchmarkDotNet/Reports/Summary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ public Summary(

private static BenchmarkCase GetFastestBenchmarkCase(ImmutableArray<BenchmarkReport> reports)
{
if (reports.Any() && reports.All(r => r.BenchmarkCase.Config.AutomaticBaselineMode == AutomaticBaselineMode.Fastest))
var baselineReport = reports.Where(r => r.BenchmarkCase.Config.AutomaticBaselineMode != AutomaticBaselineMode.None).LastOrDefault();
if (baselineReport != null && baselineReport.BenchmarkCase.Config.AutomaticBaselineMode == AutomaticBaselineMode.Fastest)
{
var fastestReport = reports.First();
if (fastestReport.ResultStatistics != null)
Expand Down