Improvements to [suggest] directive #2718
Closed
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# cherry-picked from commit c0a9f07 # zou-flow - 14.4.0.2543 net9.0
Contributor
Author
|
I'm closing this PR — I'm not satisfied with the changes and will open a replacement PR (#2719) using a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the [suggest] directive with the exact name of a command that has subcommands, you would expect the completions to include those subcommands. However, this does not happen due to how the completion logic currently determines the symbol to complete and the command line context.
Unfortunately, I am unable to run the tests on my machine.