Skip to content

Conversation

@robinvandernoord
Copy link

As suggested by @ngoldbaum in #235, I'm recreating a PR for the Python 3.14 fix without the changes in the .github/workflows/build_wheels.yml file.
This because while outlines-core works on 3.14 with the updated dependencies, not all tests pass yet due to dependencies (numba, torch) that are not yet compatible. I've attached the description of my original PR for reference:


I've updated the required dependencies (pyo3 and serde-pyobject) to versions that support Python 3.14.
This caused a compilation error when building, which I've fixed in src/python_bindings/mod.rs by adding a type hint.
Furthermore, I've added 3.14 as a build target in the build_wheels.yml github workflow.

Running make test still failed on 4 tests:

FAILED tests/test_kernels.py::test_interface_torch - RuntimeError: torch.compile is not supported on Python 3.14+
FAILED tests/test_kernels.py::test_interface_numpy - ImportError: To use the kernels in `outlines_core.kernels.numpy`, `numba` must be installed. You can install it with `pip install numba`
FAILED tests/test_kernels.py::test_torch_correctness - RuntimeError: torch.compile is not supported on Python 3.14+
FAILED tests/test_kernels.py::test_numpy_correctness - ImportError: To use the kernels in `outlines_core.kernels.numpy`, `numba` must be installed. You can install it with `pip install numba`

This is due to numba not supporting 3.14 and torch only partially supporting it.

…4, add type hint required to compile with new versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant