Refactoring - Rewrite #19
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
force-pushed
the
push-spymmsvvlvmu
branch
3 times, most recently
from
47f4b8f to
779bee1
Compare
- Remove Generators - It was not necessary to keep them - Switch to PHPUnit 11 - Remove temporarily drupol/php-conventions, deps issue with vimeo/psalm - Remove methods toArray and count - Remove custom interfaces - Update CI
drupol
force-pushed
the
push-spymmsvvlvmu
branch
from
779bee1 to
f5968c4
Compare
|
Hello, Need any help? Is the rework still in progress? Last commit is from 2 jan. |
Owner
Author
|
Hello, Sadly I don't have the time to take care of this project at the moment... do you feel like helping? |
|
I don't know, seems like a pretty static library. Could you elaborate?
Sent from [Proton Mail](https://proton.me/mail/home) for Android.
…-------- Original Message --------
On Wednesday, 11/19/25 at 20:30 Pol Dellaiera ***@***.***> wrote:
drupol left a comment [(drupol/phpermutations#19)](#19 (comment))
Hello,
Sadly I don't have the time to take care of this project at the moment... do you feel like helping?
—
Reply to this email directly, [view it on GitHub](#19 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAM5O2H6Y4IFB46I4OTURBL35TALTAVCNFSM6AAAAACMTQDKI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNJUGMYDOMZVGQ).
You are receiving this because you commented.Message ID: ***@***.***>
|
Owner
Author
|
I don't really have anything to elaborate here, I don't have time to continue on this at the moment, and if you feel like taking over, feel free to open a PR, I'll be glad to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Follows #.
Related to #.
Fixes #.