Skip to content

Conversation

@dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Nov 14, 2025

See Proposal #22494.

Depends on eclipse-omr/omr#7939


The test linter can be found here. The PR build linter (currently disabled) is here.

  1. Failed job example (triggered with the following patch)
diff --git a/runtime/compiler/exceptions/JITShutDown.hpp b/runtime/compiler/exceptions/JITShutDown.hpp
index 72681e459d..bd221861b1 100644
--- a/runtime/compiler/exceptions/JITShutDown.hpp
+++ b/runtime/compiler/exceptions/JITShutDown.hpp
@@ -30,7 +30,7 @@
 namespace J9 {

 /**
- * JIT Shutdown exception type.
+ *  JIT Shutdown exception type.
  *
  * Thrown to terminate a compile during the JIT Shutdown phase.
  */
diff --git a/runtime/vm/swalk.c b/runtime/vm/swalk.ca
index f29d5025de..86770a7bf8 100644
--- a/runtime/vm/swalk.c
+++ b/runtime/vm/swalk.c
@@ -88,7 +88,7 @@ static void getLocalsMap (J9StackWalkState * walkState, J9ROMClass * romClass, J
 static UDATA allocateCache (J9StackWalkState * walkState);
 static void dropToCurrentFrame (J9StackWalkState * walkState);

-/* The minimum number of stack slots that a stack frame can occupy */
+/*  The minimum number of stack slots that a stack frame can occupy */
 #define J9_STACKWALK_MIN_FRAME_SLOTS (OMR_MIN(sizeof(J9JITFrame), sizeof(J9SFStackFrame)) / sizeof(UDATA))

 static VMINLINE UDATA
  1. Successful job example (no compiler files)
  2. Successful job example (with compiler files)

These jobs use the .clang-format and Dockerfile from OMR. They also behave the same as the linter on OMR, namely the docker image is built every time, but remains cached on the machine; thus when run a second time, the job finishes much faster.


Similar to the OMR PR, I'll update this PR with the commits that actually format the code once we're ready to move forward.

@dsouzai
Copy link
Contributor Author

dsouzai commented Nov 14, 2025

@AdamBrousseau Does this look reasonable for what we would need to support a Code Format Linter on OpenJ9? Am I missing anything (aside from the actual job(s) on jenkins)?

@dsouzai
Copy link
Contributor Author

dsouzai commented Nov 21, 2025

@AdamBrousseau reminder ping.

@dsouzai dsouzai force-pushed the clangformat branch 2 times, most recently from 7ac32ce to 5e7d1ce Compare December 5, 2025 14:16
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@dsouzai dsouzai force-pushed the clangformat branch 3 times, most recently from a086d0e to 3dcc373 Compare December 5, 2025 15:30
@dsouzai
Copy link
Contributor Author

dsouzai commented Dec 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant