Skip to content

Fix missing backtick and incorrect variable in DiagnosticLinkInlineParser #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix missing backtick and incorrect variable in DiagnosticLinkInlineParser #2261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ea678
Initial plan
Copilot Nov 24, 2025
2827d75
Fix string formatting issues in DiagnosticLinkInlineParser
Copilot Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ private static void ValidateInternalUrl(InlineProcessor processor, string url, s
processor.EmitWarning(link, $"Local file `{url}` has a redirect, please update this reference to: {name}");
}
else
processor.EmitError(link, $"`{url}` does not exist. If it was recently removed add a redirect. resolved to `{pathOnDisk}");
processor.EmitError(link, $"`{url}` does not exist. If it was recently removed add a redirect. resolved to `{pathOnDisk}`");

}
}
Expand Down Expand Up @@ -340,7 +340,7 @@ private static void UpdateLinkUrl(LinkInline link, MarkdownFile? linkMarkdown, s
{
newUrl = newUrl.EndsWith($"{Path.DirectorySeparatorChar}index.md")
? newUrl.Remove(newUrl.LastIndexOf("index.md", StringComparison.Ordinal), "index.md".Length)
: newUrl.Remove(url.LastIndexOf(".md", StringComparison.Ordinal), ".md".Length);
: newUrl.Remove(newUrl.LastIndexOf(".md", StringComparison.Ordinal), ".md".Length);
}

// TODO this is hardcoded should be part of extension system
Expand Down
Loading