fix(legend): avoid re-rendering #2646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/charts/src/state/chart_selectors.ts:148
- Removing the export from ChartSelectorsFactory may lead to breakages if it is expected to be used externally. Confirm that this type is intended for internal use only.
type ChartSelectorsFactory = () => ChartSelectors;
packages/charts/src/chart_types/xy_chart/state/selectors/get_legend_item_extra_values.ts:24
- Using legendValues.length directly assumes that legendValues is always an array; ensure that getLegendConfigSelector always returns an array to prevent potential runtime errors.
type === ScaleType.Ordinal || legendValues.length === 0
packages/charts/src/chart_types/goal_chart/state/selectors/get_screen_reader_data.ts
Show resolved
Hide resolved
packages/charts/src/chart_types/xy_chart/state/selectors/get_legend_item_extra_values.ts
Show resolved
Hide resolved
packages/charts/src/state/selectors/get_screen_reader_summary.ts
Outdated
Show resolved
Hide resolved
Contributor
mariairiartef
left a comment
mariairiartef
left a comment
There was a problem hiding this comment.
I've left some comments!
Contributor
✅ Successful Deployment (build#5280) - fafec1a |
mariairiartef
approved these changes
Nov 4, 2025
Contributor
mariairiartef
left a comment
mariairiartef
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments!
nickofthyme
approved these changes
Nov 11, 2025
| type ChartSelectorsFactory = () => ChartSelectors; | ||
|
|
||
| const EMPTY_TOOLTIP = Object.freeze({ header: null, values: [] }); | ||
| const EMPTY_LEGEND_ITEM_LIST: LegendItemLabel[] = []; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const EMPTY_LEGEND_ITEM_LIST: LegendItemLabel[] = []; | |
| const EMPTY_LEGEND_ITEM_LIST: LegendItemLabel[] = Object.freeze([]); |
Do you think it's too much to use Object.freeze on all these? It's unlikely they would change based on our aversion to mutations but still you never know. I don't think freeze affects runtime performance in any meaningful way.
Up to you...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve legend rendering efficiency by avoiding unnecessary re-renders when the legend configuration changes. This change enhances performance and maintains the integrity of the displayed legend items.