Pass constants when building with MSBuild

FormattableString only needs to included when building .NET 4.5 so allow defining of constants when building from command line with MSBuild

Author: russcam

build/scripts/Paths.fsx

@@ -209,16 +209,16 @@ module Tooling =
 
     let DotNet = new DotNetTooling("dotnet.exe")
 
-    type DotNetFrameworkIdentifier = { MSBuild: string; Nuget: string; }
+    type DotNetFrameworkIdentifier = { MSBuild: string; Nuget: string; DefineConstants: string }
 
     type DotNetFramework = 
         | Net45 
         | Net46 
         static member All = [Net45; Net46] 
         member this.Identifier = 
             match this with
-            | Net45 -> { MSBuild = "v4.5"; Nuget = "net45"; }
-            | Net46 -> { MSBuild = "v4.6"; Nuget = "net46"; }
+            | Net45 -> { MSBuild = "v4.5"; Nuget = "net45"; DefineConstants = "TRACE;NET45"; }
+            | Net46 -> { MSBuild = "v4.6"; Nuget = "net46"; DefineConstants = "TRACE;NET46"; }
 
     type MsBuildTooling() =
        let msbuildProperties = [
@@ -227,6 +227,11 @@ module Tooling =
        ]
 
        member this.Exec output target framework projects =
-            MSBuild output target (msbuildProperties |> List.append [("TargetFrameworkVersion", framework.MSBuild)]) projects |> ignore
+            let properties = msbuildProperties 
+                             |> List.append [
+                                ("TargetFrameworkVersion", framework.MSBuild); 
+                                ("DefineConstants", framework.DefineConstants)
+                             ]
+            MSBuild output target properties projects |> ignore
 
     let MsBuild = new MsBuildTooling()

src/Elasticsearch.Net/Elasticsearch.Net.csproj

@@ -19,18 +19,18 @@
     <DebugType>full</DebugType>
     <Optimize>false</Optimize>
     <OutputPath>bin\Debug\net45\</OutputPath>
-    <DefineConstants>TRACE;DEBUG</DefineConstants>
+    <DefineConstants Condition="'$(DefineConstants)' == ''">TRACE;DEBUG</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <UseVSHostingProcess>false</UseVSHostingProcess>
     <Prefer32Bit>false</Prefer32Bit>
     <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
-  </PropertyGroup>
+  </PropertyGroup>  
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
     <Optimize>true</Optimize>
     <OutputPath>bin\Release\net45\</OutputPath>
-    <DefineConstants>TRACE;NET45</DefineConstants>
+	<DefineConstants Condition="'$(DefineConstants)' == ''">TRACE;</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <DocumentationFile>bin\Release\net45\Elasticsearch.Net.XML</DocumentationFile>

src/Elasticsearch.Net/Extensions/FormattableString.cs

@@ -1,4 +1,5 @@
-namespace System.Runtime.CompilerServices
+#if NET45
+namespace System.Runtime.CompilerServices
 {
 	internal class FormattableStringFactory
 	{
@@ -34,3 +35,4 @@ public FormattableString(string messageFormat, object[] args)
 		public string ToString(IFormatProvider formatProvider) => string.Format(formatProvider, _messageFormat, _args);
 	}
 }
+#endif