Skip to content

Disable throttling for snapshot builds #137757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Disable throttling for snapshot builds #137757

wants to merge 1 commit into from
+3 −1

Conversation

@benwtrent
Copy link
Member

@benwtrent benwtrent commented Nov 7, 2025

Some testing...

@benwtrent
Copy link
Member Author

benwtrent commented Nov 7, 2025

@mayya-sharipova @ChrisHegarty ping

@benwtrent
Copy link
Member Author

benwtrent commented Nov 7, 2025

Buildkite benchmark this with so-vector please

ChrisHegarty
ChrisHegarty reviewed Nov 7, 2025
View reviewed changes
server/src/main/java/org/elasticsearch/index/MergeSchedulerConfig.java
"index.merge.scheduler.auto_throttle",
true,
// default to false in snapshot for testing
isSnapshot == false,
Copy link
Contributor

@ChrisHegarty ChrisHegarty Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning it off for snapshot builds is a great start to help us determine the potential impact of this across different benchmarks. 👍

@benwtrent
Copy link
Member Author

benwtrent commented Nov 7, 2025

Buildkite benchmark this with dense_vector please

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 7, 2025 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

This build attempts two dense_vector benchmarks to evaluate performance impact of this PR. To estimate benchmark completion time inspect previous nightly runs here.

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

>non-issue :Search Relevance/Vectors Vector search v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benwtrent @elasticmachine @ChrisHegarty @elasticsearchmachine