-
Notifications
You must be signed in to change notification settings - Fork 18
Fix indentation in README code example #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @nightscape, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor formatting issue within the project's documentation. It specifically corrects an indentation error in a Python code example found in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an indentation error in a Python code example within the README.md file, which made the example syntactically incorrect. My review includes a suggestion to adjust the new indentation to align with the standard 4-space convention recommended by PEP 8 and used elsewhere in the document, further improving the code example's quality and consistency.
| matches = await runtime.search_tool_docs("calendar events", limit=5) | ||
| for hit in matches: | ||
| print(hit["server"], hit["tool"], hit.get("description", "")) | ||
| print(hit["server"], hit["tool"], hit.get("description", "")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the indentation. While this makes the code syntactically correct, the relative indentation is 3 spaces, which is unconventional. For better readability and consistency with other Python examples in this file and the PEP 8 style guide, I suggest using a 4-space indent here.
| print(hit["server"], hit["tool"], hit.get("description", "")) | |
| print(hit["server"], hit["tool"], hit.get("description", "")) |
|
Please squash-merge this, the first indentation was also wrong 😉 |
No description provided.