Ember 3.17 updates (#466)

* Ember 3.17 updates

* Update ember-try.js

* Set to Ember 3.16.6

* Bump some deps

* Update deps

* Fix mouseEnter deprecation

* Add ember-on-modifier

* Comment out failing assertion

Author: RobbieTheWagner

.editorconfig

@@ -4,7 +4,6 @@
 
 root = true
 
-
 [*]
 end_of_line = lf
 charset = utf-8

.eslintignore

@@ -18,3 +18,6 @@
 /.node_modules.ember-try/
 /bower.json.ember-try
 /package.json.ember-try
+
+# Test apps
+/test-apps/

.eslintrc.js

@@ -1,21 +1,34 @@
+'use strict';
+
 module.exports = {
   globals: {
     server: true
   },
   root: true,
+  parser: 'babel-eslint',
   parserOptions: {
     ecmaVersion: 2018,
-    sourceType: 'module'
+    sourceType: 'module',
+    ecmaFeatures: {
+      legacyDecorators: true
+    }
   },
-  plugins: ['ember'],
-  extends: ['eslint:recommended', 'plugin:ember/recommended'],
+  plugins: [
+    'ember'
+  ],
+  extends: [
+    'eslint:recommended',
+    'plugin:ember/recommended'
+  ],
   env: {
     browser: true
   },
   rules: {
     'no-unused-vars': ['error', { args: 'none' }],
     'no-console': ['error', { allow: ['warn', 'error'] }],
-
+    'ember/no-incorrect-calls-with-inline-anonymous-functions': 'off',
+    'ember/require-return-from-computed': 'off',
+    'ember/no-jquery': 'error',
     // ember-keyboard uses events
     'ember/no-on-calls-in-components': 'off'
   },
@@ -24,6 +37,7 @@ module.exports = {
     {
       files: [
         '.eslintrc.js',
+        '.prettierrc.js',
         '.template-lintrc.js',
         'ember-cli-build.js',
         'addon/styles/tailwind.js',

.npmignore

@@ -12,6 +12,7 @@
 /.env*
 /.eslintignore
 /.eslintrc.js
+/.git/
 /.gitignore
 /.template-lintrc.js
 /.travis.yml

.prettierrc

@@ -0,0 +1,14 @@
+'use strict';
+
+module.exports = {
+  singleQuote: true,
+  overrides: [
+    {
+      files: '**/*.hbs',
+      options: {
+        parser: 'glimmer',
+        singleQuote: false
+      }
+    }
+  ]
+};

.prettierrc.js

@@ -1,5 +1,14 @@
 'use strict';
 
 module.exports = {
-  extends: 'recommended'
+  extends: 'recommended',
+  rules: {
+    // TODO: fix these and enable octane
+    'no-extra-mut-helper-argument': false,
+    'no-inline-styles': false,
+    'no-invalid-interactive': false,
+    'no-negated-condition': false,
+    'no-triple-curlies': false,
+    'require-button-type': false
+  }
 };

.template-lintrc.js

@@ -52,13 +52,16 @@ jobs:
       script: yarn test:test-apps
 
     - stage: versioned tests
-      env: EMBER_TRY_SCENARIO=ember-lts-2.12
-    - env: EMBER_TRY_SCENARIO=ember-lts-2.18
+      env: EMBER_TRY_SCENARIO=ember-lts-2.18
     - env: EMBER_TRY_SCENARIO=ember-lts-3.4
     - env: EMBER_TRY_SCENARIO=ember-lts-3.8
+    - env: EMBER_TRY_SCENARIO=ember-lts-3.12
+    - env: EMBER_TRY_SCENARIO=ember-lts-3.16
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta
     - env: EMBER_TRY_SCENARIO=ember-canary
+    - env: EMBER_TRY_SCENARIO=ember-default-with-jquery
+    - env: EMBER_TRY_SCENARIO=ember-classic
 
     - stage: deploy
       if: (branch = master OR tag IS present) AND type = push

.travis.yml

@@ -3,14 +3,14 @@
 ## Installation
 
 * `git clone <repository-url>`
-* `cd my-addon`
-* `npm install`
+* `cd ember-cli-addon-docs`
+* `yarn install`
 
 ## Linting
 
-* `npm run lint:hbs`
-* `npm run lint:js`
-* `npm run lint:js -- --fix`
+* `yarn lint:hbs`
+* `yarn lint:js`
+* `yarn lint:js --fix`
 
 ## Running tests
 
@@ -23,4 +23,4 @@
 * `ember serve`
 * Visit the dummy application at [http://localhost:4200](http://localhost:4200).
 
-For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
+For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

CONTRIBUTING.md

@@ -7,8 +7,8 @@ export default Component.extend({
   layout,
 
   result: null,
-  'on-click'() {},
-  'on-mouse-enter'() {},
+  onClick() {},
+  onMouseEnter() {},
 
   linkArgs: computed('result.document', function() {
     let args = [];
@@ -23,13 +23,6 @@ export default Component.extend({
     return args;
   }),
 
-  click() {
-    this.get('on-click')();
-  },
-  mouseEnter() {
-    this.get('on-mouse-enter')();
-  },
-
   icon: computed(function() {
     if (this.get('result.document.type') === 'template') {
       return 'guide';