Improve circularbuffer performance by removing redundant fields #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve circular buffer performance by removing redundant fields `full` and `maxSize` in `Queue` and simplifying the Enqueue().
```
goos: linux
goarch: amd64
pkg: github.com/emirpasic/gods/v2/queues/circularbuffer
cpu: Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
ArrayQueueDequeue100-8 43.09n ± 1% 33.10n ± 0% -23.20% (n=50)
ArrayQueueDequeue1000-8 359.5n ± 0% 260.6n ± 0% -27.52% (n=50)
ArrayQueueDequeue10000-8 3.541µ ± 0% 2.530µ ± 0% -28.55% (n=50)
ArrayQueueDequeue100000-8 35.24µ ± 0% 25.19µ ± 0% -28.52% (n=50)
ArrayQueueEnqueue100-8 488.9n ± 0% 331.3n ± 0% -32.23% (n=50)
ArrayQueueEnqueue1000-8 4.826µ ± 0% 3.316µ ± 0% -31.30% (n=50)
ArrayQueueEnqueue10000-8 48.23µ ± 0% 33.21µ ± 1% -31.16% (n=50)
ArrayQueueEnqueue100000-8 482.7µ ± 0% 331.0µ ± 0% -31.43% (n=50)
geomean 4.249µ 3.004µ -29.29%
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
ArrayQueueDequeue100-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueDequeue1000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueDequeue10000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueDequeue100000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueEnqueue100-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueEnqueue1000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueEnqueue10000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueEnqueue100000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
geomean ² +0.00% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
ArrayQueueDequeue100-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueDequeue1000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueDequeue10000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueDequeue100000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueEnqueue100-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueEnqueue1000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueEnqueue10000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
ArrayQueueEnqueue100000-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=50) ¹
geomean ² +0.00% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can maintain
maxSizeusing the capacity and length ofvalues, and determine thefullflag by checking whethersizeis equal to the capacity (or length) ofvalues.In addition, in
Enqueue(), when the queue is full, we can simply update the value ofstartinstead of callingDequeue(), as the overhead of callingDequeue()is higher than updating the value ofstart.ArrayQueueDequeue.ArrayQueueEnqueue.