Upload images in asset descriptions #14247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
changed the title
farmaazon
force-pushed
the
wip/farmaazon/upload-enso-img
branch
from
197ec8b to
c83e3d4
Compare
farmaazon
requested review from
AdRiley,
Frizi,
PabloBuchu,
indiv0,
kazcw,
somebody1234 and
vitvakatu
as code owners
kazcw
approved these changes
Nov 7, 2025
app/common/src/services/Backend.ts
Outdated
| ): Promise<UploadedAsset> | ||
| /** | ||
| * Upload set of Images, resoliving any possible conflicts. The sum of file sizes may not | ||
| * exceed could message limit. |
Contributor
There was a problem hiding this comment.
should this say "cloud message limit"?
| title: string, | ||
| ): Promise<backend.ListDirectoryResponseBody> { | ||
| if (query.recentProjects && query.from) { | ||
| if (query.recentProjects === true && query.from) { |
Contributor
There was a problem hiding this comment.
I don't see the reason for this change. Looking at the type, this is boolean | undefined, so === true is the same as a truthiness check, right?
Contributor
Author
There was a problem hiding this comment.
There's some dashboard's lint forbidding me simple truthiness check. But at this point, I may as good just disable this check,
| } | ||
|
|
||
| /** | ||
| * Upload set of Images, resoliving any possible conflicts. The sum of file sizes may not |
Co-authored-by: Keziah Wesley <kaz@lambdaverse.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #13706
Screencast.From.2025-11-05.14-06-29.mp4
Important Notes
Cloud backend allows uploading many images at once, but it was not easy to use in current AsyncResources implementation without refactoring.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.