Refactor Definition Scala IR to Java #14252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirathan
added
CI: No changelog needed
5 tasks
This reverts commit 6a2b121.
Akirathan
commented
Nov 7, 2025
| if (isProcessingDefinitionType()) { | ||
| specialHandling.append( | ||
| """ | ||
| // Special case - name of Definition.Type is ignored. |
Member
Author
There was a problem hiding this comment.
This special handling needs to be there because the previous Defnition.Type.mapExpressions at https://github.com/enso-org/enso/pull/14252/files#diff-469ce9a70600d58340eae355c9c8a9557d84f08e0edbf53be06f3dd29fb33430L131-L134 ignored the name field.
Akirathan
commented
Nov 7, 2025
| moduleContext: ModuleContext | ||
| ): Module = { | ||
| ir.copyWithBindings(bindings = ir.bindings.map(analyseModuleDefinition)) | ||
| ir.copyWithBindings(ir.bindings.map(analyseModuleDefinition)) |
Member
Author
There was a problem hiding this comment.
In these refactorings, I am removing named arguments when calling Java from Scala, because:
- It sometimes causes compilation errors with weird messages.
- IntelliJ always treats it as an error.
- Despite the fact that
runtime-parseris compiled with-parametersflag.
JaroslavTulach
approved these changes
Nov 7, 2025
github-project-automation
bot
moved this from 🔧 Implementation
to 🌟 Q/A review
in Issues Board
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14115.
Continuation of #14217.
Blocks #14244.
Pull Request Description
Refactor
org.enso.compiler.core.ir.module.scope.DefinitionScala case class to Java.Important Notes
mapExpressionscontract at https://github.com/enso-org/enso/pull/14252/files#r2503337320Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.