⬆️ Replace mdformat-frontmatter with mdformat-front-matters
#46
Conversation
kdeldycke
force-pushed
the
fix-mdformat-frontmatter-dependency
branch
from
6dfa0e0 to
f26b25b
Compare
kdeldycke
force-pushed
the
fix-mdformat-frontmatter-dependency
branch
2 times, most recently
from
95afeee to
6667793
Compare
kdeldycke
force-pushed
the
fix-mdformat-frontmatter-dependency
branch
2 times, most recently
from
c7d33a7 to
a9e2b47
Compare
kdeldycke
force-pushed
the
fix-mdformat-frontmatter-dependency
branch
2 times, most recently
from
164faf3 to
bb70265
Compare
Run tests on Python 3.14 and 3.15-dev
Run tests on Python 3.14 and 3.15-dev
kdeldycke
force-pushed
the
fix-mdformat-frontmatter-dependency
branch
from
bb70265 to
487b64a
Compare
kdeldycke
changed the title
mdformat-frontmatter with mdformat-front-mattersmdformat-frontmatter with mdformat-front-matters
|
All tests are passing, this PR is ready to me merged upstream. |
KyleKing
left a comment
KyleKing
left a comment
There was a problem hiding this comment.
Looks good, thanks! I can approve, merge, and release once these comments are addressed
| --- | ||
| lastname: Blorothy | ||
| firstname: Dorothy | ||
| lastname: Blorothy |
There was a problem hiding this comment.
Will the change in default to sort front matter be an issue for MyST adoption? If so, I can flip the default for better backward compatibility
There was a problem hiding this comment.
Good point! We both need input from mdformat-myst maintainers here.
There was a problem hiding this comment.
There hasn't been any input, so I think we can proceed. I'll communicate this change in the changelog and how to turn it off, then making a breaking release for both that dependency swap and dropping 3.9!
There was a problem hiding this comment.
Actually, can you hold off on merging?
I’m going to release a 1.0.0 tonight that doesn’t sort by default. For most, frontmatter is manually written, so better to keep however it was ordered: eyeseast/python-frontmatter#26 (comment)
There was a problem hiding this comment.
Yeah sure! Take your time! :)
Run tests on Python 3.14 and 3.15-dev
kdeldycke
force-pushed
the
fix-mdformat-frontmatter-dependency
branch
from
487b64a to
c71ac9b
Compare
| --- | ||
| lastname: Blorothy | ||
| firstname: Dorothy | ||
| lastname: Blorothy |
There was a problem hiding this comment.
There hasn't been any input, so I think we can proceed. I'll communicate this change in the changelog and how to turn it off, then making a breaking release for both that dependency swap and dropping 3.9!
2 participants
mdformat-frontmatteris not compatible with mdformat 1.0.0, and seems unmaintained.This PR replace it with
mdformat-front-matters, which is actively maintained by @KyleKing and is becoming the de-facto frontmatter plugin in themdformatuniverse, because of its adoption bymdformat-mkdocs.This PR addresses #45.
Also to align the requirements with its dependencies, this PR bump the minimal Python version from 3.9 to 3.10. As a bonus, I activated tests on Python 3.14 and 3.15-dev.
Relates to:
mdformat < 0.8.0requirement butler54/mdformat-frontmatter#37