Introduce v1 and v2 for Trunc #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of attributes
grabs CustomOp instance with the right opset version from protobuf imported opsets
Replace manual dict registration with automatic class discovery and version resolution. CustomOps now declare op_version attribute and are auto-registered via module imports. - Add op_version attribute to all CustomOp base and subclasses - Implement nested registry structure (domain->op_type->version) - Support "since version" semantics for automatic version resolution - Replace is_finn_op() with is_custom_op() from registry - Add registry API (add_op_to_domain, get_supported_versions, is_custom_op) - Simplify domain __init__.py files to use __all__ exports - Use lazy loading via __all__ for performance
…e inference CustomOp version is now determined solely by _vN class name suffix: - No suffix defaults to version 1 - _vN suffix indicates version N - Removes redundant op_version class attribute across all CustomOp implementations - Updates registry to extract version from class names only - Adds backward compatibility for legacy custom_op dict pattern - Simplifies version discovery logic with custom_op dict fallback
Contributor
|
FYI, the Trunc / AvgPool tests in Brevitas are currently disabled. Prior to merging this, we may want to run these tests locally on the Brevitas side to check we don't have any regressions. |
…pversion_and_trunc_v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #217
Incorporates/supersedes #170
Uses the custom op versioning system in #217 to introduce versioned
Truncops, namelyTrunc_v1andTrunc_v2(which itself is introduced by #170). Also updates the documentation for the custom ops to specify the version number and adds an overview table from which the different versions are indexed.