Skip to content

Add Agent Eval assertions on files #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Agent Eval assertions on files #9372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9c8081
Add Agent Eval assertions on files
samedson Oct 22, 2025
aecf2b4
Apply suggestion from @gemini-code-assist[bot]
samedson Oct 23, 2025
8e2c9f9
Stuff
samedson Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
229 changes: 213 additions & 16 deletions scripts/agent-evals/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion scripts/agent-evals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@
"author": "",
"license": "ISC",
"devDependencies": {
"@types/chai": "^4.3.0",
"@types/chai-fs": "^2.0.5",
"@types/mocha": "^9.0.0",
"@types/node": "^24.9.0"
"@types/node": "^24.9.0",
"chai-fs": "^2.0.0"
},
"dependencies": {
"mocha": "^11.7.1",
Expand Down
7 changes: 7 additions & 0 deletions scripts/agent-evals/src/runner/agent-test-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ToolDef } from "./tool-matcher.js";
import {Assertion} from "chai";

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

'Assertion' is defined but never used

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

Replace `Assertion` with `·Assertion·`

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

'Assertion' is defined but never used

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

Replace `Assertion` with `·Assertion·`

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

'Assertion' is defined but never used

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

Replace `Assertion` with `·Assertion·`

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

'Assertion' is defined but never used

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

Replace `Assertion` with `·Assertion·`

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

'Assertion' is defined but never used

Check failure on line 2 in scripts/agent-evals/src/runner/agent-test-runner.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Replace `Assertion` with `·Assertion·`

export interface AgentTestRunner {
/**
Expand All @@ -19,4 +20,10 @@
* an event is not found
*/
expectToolCalls(tools: ToolDef[]): Promise<void>;

/**
* Returns an assertion object for the path inside the run directory that can
* be asserted on via chai-fs's API: https://www.chaijs.com/plugins/chai-fs/
*/
expectFs(filePath: string): Chai.Assertion;
}
Loading
Loading