Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/node-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
# - name: Setup Java JDK
# uses: actions/setup-java@v3.3.0
# with:
# java-version: 17
# java-version: 21
# distribution: temurin

# - uses: actions/checkout@v4
Expand Down Expand Up @@ -188,6 +188,11 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: npm
cache-dependency-path: npm-shrinkwrap.json
- name: Setup Java JDK
uses: actions/setup-java@v3.3.0
with:
java-version: 21
distribution: temurin
- name: Setup Chrome
uses: browser-actions/setup-chrome@v1.7.2
with:
Expand Down Expand Up @@ -247,7 +252,7 @@ jobs:
- name: Setup Java JDK
uses: actions/setup-java@v3.3.0
with:
java-version: 17
java-version: 21
distribution: temurin

- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Add a confirmation in `firebase init dataconnect` before asking for app idea description. (#9282)
- [BREAKING] Removes support for running emulators with Java versions prior to 21.
2 changes: 1 addition & 1 deletion src/emulator/commandUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -589,5 +589,5 @@ export async function checkJavaMajorVersion(): Promise<number> {

export const MIN_SUPPORTED_JAVA_MAJOR_VERSION = 21;
export const JAVA_DEPRECATION_WARNING =
"firebase-tools will drop support for Java version < 21 soon in firebase-tools@15. " +
"firebase-tools no longer supports Java version before 21. " +
"Please install a JDK at version 21 or above to get a compatible runtime.";
3 changes: 1 addition & 2 deletions src/emulator/controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,7 @@ export async function startAll(
const deprecationNotices: string[] = [];
if (targets.some(requiresJava)) {
if ((await commandUtils.checkJavaMajorVersion()) < MIN_SUPPORTED_JAVA_MAJOR_VERSION) {
utils.logLabeledError("emulators", JAVA_DEPRECATION_WARNING, "warn");
deprecationNotices.push(JAVA_DEPRECATION_WARNING);
throw new FirebaseError(JAVA_DEPRECATION_WARNING);
}
}
if (options.logVerbosity) {
Expand Down
Loading