Refactor/push notification registration

[fulleni]

Status

READY

Description

This pull request refactors the push notification registration mechanism to enhance reliability and user experience. The core change involves a more robust approach to managing device registrations, ensuring that users consistently receive notifications on their most current device by clearing out older registrations and assigning unique identifiers to new ones. This addresses potential issues with 'ghost' notifications and streamlines the registration flow.

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[gemini-code-assist]

Summary of Changes

Hello @fulleni, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the push notification registration mechanism to enhance reliability and user experience. The core change involves a more robust approach to managing device registrations, ensuring that users consistently receive notifications on their most current device by clearing out older registrations and assigning unique identifiers to new ones. This addresses potential issues with 'ghost' notifications and streamlines the registration flow.

Highlights

• Proactive Device Cleanup: The push notification registration process for both Firebase and OneSignal now proactively reads and deletes all existing device registrations for a user before creating a new one. This prevents 'ghost' notifications from being sent to old, unused installations.
• Unique Device ID Generation: Device IDs are no longer generated as a composite key (e.g., 'userId_providerName'). Instead, each new device registration receives a universally unique identifier (UUID) using Uuid().v4().
• Robust Error Handling for Cleanup: If the proactive cleanup of existing devices fails (e.g., due to network issues), the registration process will still proceed. The error is logged, and the system relies on the backend's passive self-healing mechanism to eventually prune orphaned device records, ensuring new device registration is not blocked.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the push notification registration logic to ensure a user only receives notifications on their most recently used device. This is achieved by deleting all of a user's previous device registrations before creating a new one. The changes are consistently applied across both the Firebase and OneSignal notification services. My feedback focuses on improving code quality by suggesting the reuse of the Uuid instance for better performance and abstracting the duplicated device cleanup logic to enhance maintainability.