Skip to content

Conversation

@fulleni
Copy link
Member

@fulleni fulleni commented Nov 22, 2025

Status

READY

Description

This pull request introduces a new feature to visually highlight breaking news headlines within the application. By adding a localized 'Breaking News' prefix to relevant titles, users can quickly identify urgent information. This enhancement improves the user experience by providing clearer visual cues for important news items across different display formats and languages.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

- Add Arabic and English translations for breaking news prefix
- Update app_ar.arb and app_en.arb files with new translations
- Include description for breaking news prefix in both language files
- Add localization support for breaking news prefix
- Implement Text.rich for headline title to support breaking news indication
- Allow title to span up to 3 lines instead of 2 for better readability
- Add localization support for breaking news prefix
- Implement Text.rich for headline title to support breaking news indicator
- Adjust maxLines from 2 to 3 for better readability
…tion

- Add localization support for breaking news prefix
- Display breaking news prefix for breaking news articles
- Style breaking news prefix with primary color and bold font weight
@gemini-code-assist
Copy link

Summary of Changes

Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature to visually highlight breaking news headlines within the application. By adding a localized 'Breaking News' prefix to relevant titles, users can quickly identify urgent information. This enhancement improves the user experience by providing clearer visual cues for important news items across different display formats and languages.

Highlights

  • New Localization Key: A new localization key, breakingNewsPrefix, has been added to support a 'Breaking News' label for headlines. This key is implemented in both English and Arabic.
  • Headline Display Enhancement: The headline display widgets (headline_tile_image_start.dart, headline_tile_image_top.dart, headline_tile_text_only.dart) have been updated to conditionally prepend the localized 'Breaking News' prefix to headline titles if the headline.isBreaking flag is true. The prefix is styled with a bold, primary color.
  • Improved Readability: The maximum number of lines for headline titles in the display widgets has been increased from 2 to 3 to accommodate the new prefix and potentially longer titles.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds a 'Breaking News' prefix to headline titles for breaking news articles. The implementation correctly introduces new localization strings and updates the relevant headline widgets to display the prefix using Text.rich for styling. The code is functional, but there is significant code duplication in the three headline tile widgets. I've left a comment suggesting a refactor to extract the title-rendering logic into a separate, reusable widget to improve maintainability.

- Reduce maxLines from 3 to 2 in HeadlineTileImageStart
- Reduce maxLines from 3 to 2 in HeadlineTileImageTop
- Reduce maxLines from 3 to 2 in HeadlineTileTextOnly

This change improves the consistency and readability of headline titles across different feed tile layouts.
@fulleni fulleni merged commit 345b268 into main Nov 22, 2025
0 of 2 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Flutter News App Project Nov 22, 2025
@fulleni fulleni deleted the feat-Add-Breaking-News-Prefix-to-Headline-Titles branch November 22, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants