Skip to content

Remove hardcoded useWasm: false for expectedBenchmarkMetrics() #9518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove hardcoded useWasm: false for expectedBenchmarkMetrics() #9518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/devtools_app/benchmark/devtools_benchmarks_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,7 @@ Future<void> _runBenchmarks({bool useWasm = false}) async {

for (final devToolsBenchmark in DevToolsBenchmark.values) {
final benchmarkName = devToolsBenchmark.id;
// Note: Due to https://github.com/flutter/flutter/pull/175392 there is no
// longer any difference in benchmark events for skwasm vs. canvaskit.
//
// TODO(https://github.com/flutter/flutter/issues/177057): Remove hardcoded
// useWasm: false param when package:web_benchmarks is updated.
final expectedMetrics = expectedBenchmarkMetrics(useWasm: false);
final expectedMetrics = expectedBenchmarkMetrics();
const expectedComputations = BenchmarkMetricComputation.values;
final scores = taskResult.scores[benchmarkName] ?? [];
expect(
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ dev_dependencies:
stager: ^1.3.0
stream_channel: ^2.1.1
test: ^1.21.0
web_benchmarks: ^4.0.0
web_benchmarks: ^4.1.0
webkit_inspection_protocol: ">=0.5.0 <2.0.0"

flutter:
Expand Down
Loading