[camera_android_camerax] use MediaSettings::fps for image preview, streaming, and video recording #10301

dasyad00 · 2025-10-25T12:37:54Z

Implements MediaSettings::fps in camera_android_camerax for image preview, image streaming, and video recording.

Resolves #167719: implements the feature instead of adding documentation that it does not work.
Partially resolves #176148: only implements for camera_android_camerax, and uses the existing MediaSettings::fps instead of adding parameters to CameraImageStreamOptions

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

camsim99

This looks great! Thank you so much for taking this on. This will be a huge improvement to the plugin!

I think we need to add a Dart test, but otherwise LGTM. Let's get a second review.

camsim99 · 2025-10-27T16:53:03Z

...mera_android_camerax/android/src/test/java/io/flutter/plugins/camerax/ImageAnalysisTest.java


 @RunWith(RobolectricTestRunner.class)
 public class ImageAnalysisTest {
+  @SuppressWarnings({"unchecked", "rawtypes"})


Nit: where you added this annotation, can you leave a comment as to why this is safe?

"rawtypes" is required because the current version of Mockito (5.19.0) does not yet support the ability to mock construction of generic types. However, I see that it is now supported as of very recently. Should I try to update the Mockito version in the project to 5.20.0?

Introducing the Ability to Mock Construction of Generic Types mockito/mockito#2401

Introducing the Ability to Mock Construction of Generic Types (#2401) mockito/mockito#3729 (merged 2025/09/20)

"unchecked" is related to the point above. Since MockedConstruction does not support generic types, mock.setCaptureRequestOption is forced to use a raw type.

Let me know whether I should try upgrading Mockito, or just leave a comment about it.

Upgrading mockito if possible would be great!

If you run into issues, though, feel free to open an issue andwe can take a look. Though, I just meant to leave a comment in the code so we remember why we added the suppression, so if you don't upgrade mockito, can you do that?

I've just added a comment for the rationale behind the warning suppression: c954355.

Apparently it's a limitation of Java and not Mockito.

camsim99 · 2025-10-27T17:06:08Z

packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart

I think we should add a test to make sure that if the fps media setting is passed, we actually set it as expected. I know these test are a bit daunting to write so let me know if you need help 😅

Just in case you need help getting started: The hardest part is mocking the pigeon calls. There are several other createCamera tests you can copy or modify to handle the mocks, though. But there are some helper methods at the top of the file that can help with that. I think you could end up doing something like

packages/packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart

Lines 4649 to 4662 in 3404a0b

newCameraSelector:

({

LensFacing? requireLensFacing,

CameraInfo? cameraInfoForFilter,

// ignore: non_constant_identifier_names

BinaryMessenger? pigeon_binaryMessenger,

// ignore: non_constant_identifier_names

PigeonInstanceManager? pigeon_instanceManager,

}) {

if (cameraInfoForFilter == mockFrontCameraInfo) {

return mockFrontCameraSelector;

}

return mockBackCameraSelector;

},

where can check the fps and return a mock object then check that the use case (like camera.videoCapture) equals your mock object.

I've added a unit test in 4abed18. Was this what you had in mind?

Great thanks! This looks good to me.

bparrishMines

LGTM pending unit tests and updating the lint-baseline.xml.

bparrishMines · 2025-10-28T18:57:18Z

..._android_camerax/android/src/main/java/io/flutter/plugins/camerax/ImageAnalysisProxyApi.java

 class ImageAnalysisProxyApi extends PigeonApiImageAnalysis {
  static final long CLEAR_FINALIZED_WEAK_REFERENCES_INTERVAL_FOR_IMAGE_ANALYSIS = 1000;

+  @OptIn(markerClass = ExperimentalCamera2Interop.class)


This plugin updates [lint-baseline.xml] (https://github.com/flutter/packages/blob/main/packages/camera/camera_android_camerax/android/lint-baseline.xml) to handle this specific warning.

This should be updateable by following https://developer.android.com/studio/write/lint#snapshot in the example app. But this can be updated after getting both LGTMs.

I just tried to run this (./gradlew lintDebug -Dlint.baselines.continue=true) inside of the camera_android_camerax/example/android directory, but I see that lint-baseline.xml only contains references to src/main/java/io/flutter/plugins/camerax/CameraXLibrary.g.kt.

I also see @OptIn(markerClass = ExperimentalCamera2Interop.class) already used in Camera2CameraControlProxyApi.java and Camera2CameraInfoProxyApi.java

packages/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/Camera2CameraControlProxyApi.java

Line 26 in 1a7075b

@OptIn(markerClass = ExperimentalCamera2Interop.class)

packages/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/Camera2CameraInfoProxyApi.java

Line 21 in 1a7075b

@OptIn(markerClass = ExperimentalCamera2Interop.class)

Is this to be expected?

Ah, good catch! @camsim99 was baseline intended to only be used for the CameraXLibrary.g.kt?

Ideally, the baseline should only handles lints caused by generated code since we can't control it, though I'm open to it in certain cases. I think keeping this annotation could be nice so we can easily identify experimental CameraX features.

camsim99

LGTM, thanks for the fixes :)

camsim99 · 2025-11-10T16:21:25Z

...mera_android_camerax/android/src/test/java/io/flutter/plugins/camerax/ImageAnalysisTest.java


 @RunWith(RobolectricTestRunner.class)
 public class ImageAnalysisTest {
+  @SuppressWarnings({"unchecked", "rawtypes"})


Upgrading mockito if possible would be great!

If you run into issues, though, feel free to open an issue andwe can take a look. Though, I just meant to leave a comment in the code so we remember why we added the suppression, so if you don't upgrade mockito, can you do that?

camsim99 · 2025-11-10T16:23:04Z

packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart

Great thanks! This looks good to me.

stuartmorgan-g · 2025-11-18T16:57:23Z

From triage: @bparrishMines It looks like this had your preliminary LGTM, but needs a final re-review and approval.

bparrishMines · 2025-11-20T18:30:02Z

packages/camera/camera_android_camerax/pigeons/camerax_library.dart

 )
 abstract class Preview extends UseCase {
-  Preview(int? targetRotation);
+  Preview(int? targetRotation, int? targetFps);


It looks like this takes a range in the Java code. This should use CameraIntegerRange defined in this file instead. Same for the other classes.

I've reworked it so that we pass CameraIntegerRange instead of int

bparrishMines

This looks mostly good to me. Just a comment on the type passed for the fps.

…ax/control_fps

bparrishMines

LGTM

…review, streaming, and video recording (flutter/packages#10301)

flutter/packages@5d8d954...b505d41 2025-11-26 dasyad00@gmail.com [camera_android_camerax] use MediaSettings::fps for image preview, streaming, and video recording (flutter/packages#10301) 2025-11-26 stuartmorgan@google.com [various] Update READMEs to reflect current OS support (flutter/packages#10470) 2025-11-26 engine-flutter-autoroll@skia.org Roll Flutter from 3f553f6 to 7b98d50 (30 revisions) (flutter/packages#10523) 2025-11-26 alex@swipelab.co [camera] fix RECORD_AUDIO permission on Android when there is no permission (flutter/packages#10424) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#179188) flutter/packages@5d8d954...b505d41 2025-11-26 dasyad00@gmail.com [camera_android_camerax] use MediaSettings::fps for image preview, streaming, and video recording (flutter/packages#10301) 2025-11-26 stuartmorgan@google.com [various] Update READMEs to reflect current OS support (flutter/packages#10470) 2025-11-26 engine-flutter-autoroll@skia.org Roll Flutter from 3f553f6 to 7b98d50 (30 revisions) (flutter/packages#10523) 2025-11-26 alex@swipelab.co [camera] fix RECORD_AUDIO permission on Android when there is no permission (flutter/packages#10424) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added p: camera platform-android labels Oct 25, 2025

dasyad00 force-pushed the androix_camerax/control_fps branch from 6707def to 3404a0b Compare October 25, 2025 13:40

dasyad00 marked this pull request as ready for review October 25, 2025 13:40

dasyad00 requested a review from camsim99 as a code owner October 25, 2025 13:40

camsim99 reviewed Oct 27, 2025

View reviewed changes

camsim99 requested a review from bparrishMines October 27, 2025 17:07

bparrishMines reviewed Oct 28, 2025

View reviewed changes

camsim99 self-requested a review November 4, 2025 16:28

camsim99 approved these changes Nov 10, 2025

View reviewed changes

camsim99 requested a review from bparrishMines November 10, 2025 16:25

dasyad00 force-pushed the androix_camerax/control_fps branch from c954355 to 9ec4f0a Compare November 11, 2025 09:14

bparrishMines reviewed Nov 20, 2025

View reviewed changes

bparrishMines requested changes Nov 20, 2025

View reviewed changes

dasyad00 added 9 commits November 23, 2025 16:42

add targetFps

57d7add

remove printing stacktrace

fa08f2e

format modified files

da3a555

bump camera_android_camerax version 0.6.25

f3853c8

document targetFps variable

7663952

assert Camera2Interop.Extender is constructed

b23cc93

add CameraController fps dart test

d8b7111

document rationale for warning suppression

e2f9c24

use CameraIntegerRange for target fps

9439f17

dasyad00 force-pushed the androix_camerax/control_fps branch from 9ec4f0a to 9439f17 Compare November 23, 2025 18:04

fix dart implementation of fps range

d13436c

dasyad00 force-pushed the androix_camerax/control_fps branch from 7545acf to d13436c Compare November 23, 2025 19:25

dasyad00 requested a review from bparrishMines November 23, 2025 19:55

Merge branch 'main' of github.com:flutter/packages into androix_camer…

f9fc2d0

…ax/control_fps

bparrishMines approved these changes Nov 26, 2025

View reviewed changes

bparrishMines added 2 commits November 26, 2025 14:22

use present tense in changelog

455a47e

lint update

b4cd9d4

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 26, 2025

auto-submit bot merged commit b505d41 into flutter:main Nov 26, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 27, 2025

b505d41ad [camera_android_camerax] use MediaSettings::fps for image p…

dcfc1f3

…review, streaming, and video recording (flutter/packages#10301)

engine-flutter-autoroll mentioned this pull request Nov 27, 2025

Roll Packages from 5d8d954b7c5e to b505d41ade71 (4 revisions) flutter/flutter#179188

Merged

	newCameraSelector:
	({
	LensFacing? requireLensFacing,
	CameraInfo? cameraInfoForFilter,
	// ignore: non_constant_identifier_names
	BinaryMessenger? pigeon_binaryMessenger,
	// ignore: non_constant_identifier_names
	PigeonInstanceManager? pigeon_instanceManager,
	}) {
	if (cameraInfoForFilter == mockFrontCameraInfo) {
	return mockFrontCameraSelector;
	}
	return mockBackCameraSelector;
	},

[camera_android_camerax] use MediaSettings::fps for image preview, streaming, and video recording #10301

[camera_android_camerax] use MediaSettings::fps for image preview, streaming, and video recording #10301

Conversation

dasyad00 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Nov 18, 2025

Uh oh!

bparrishMines Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dasyad00 commented Oct 25, 2025 •

edited

Loading

bparrishMines Nov 20, 2025 •

edited

Loading