feat(ios): add audio track selection support for AVFoundation #10313

nateshmbhat · 2025-10-28T15:06:34Z

Implemented getAudioTracks() method to retrieve available audio tracks from both HLS streams and regular video files

AVFoundation Platform PR for : #9925

Pre-Review Checklist

gemini-code-assist

Code Review

This pull request introduces audio track selection support for AVFoundation, enabling users to retrieve and select audio tracks from both HLS streams and regular video files. The changes include modifications to the CHANGELOG, platform-specific code (ObjC, Swift), example app, and test files. The minimum supported SDK versions have been updated, and new methods (getAudioTracks(), selectAudioTrack()) have been implemented. The code adheres to the repository's style guide, focusing on objective summaries and using code as the source of truth.

gemini-code-assist · 2025-10-28T15:12:29Z

packages/video_player/video_player_avfoundation/CHANGELOG.md


-* Updates minimum supported version to iOS 13 and macOS 10.15.
-* Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.
+* Implements `getAudioTracks()` and `selectAudioTrack()` methods.


It's great to see the new features documented in the changelog. However, consider adding a bit more detail about the specific use cases or benefits of these methods for developers.

packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation.podspec

packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Package.swift

gemini-code-assist · 2025-10-28T15:12:30Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+      // Skip nil options
+      if (!option || [option isKindOfClass:[NSNull class]]) {
+        continue;


Consider adding a comment explaining why nil options are skipped. This will help future developers understand the logic behind this check.

+1, why are we checking against NSNull or checking if the option is nil?

gemini-code-assist · 2025-10-28T15:12:30Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+  }
+  // For asset tracks, we don't have a direct way to select them in AVFoundation
+  // This would require more complex track selection logic that's not commonly used


Add a comment explaining why direct selection isn't possible and what the limitations are. This will help future developers understand the current implementation and potential areas for improvement.

packages/video_player/video_player_avfoundation/example/ios/Flutter/AppFrameworkInfo.plist

packages/video_player/video_player_avfoundation/example/ios/Runner.xcodeproj/project.pbxproj

packages/video_player/video_player_avfoundation/example/macos/Podfile

packages/video_player/video_player_avfoundation/example/macos/Runner.xcodeproj/project.pbxproj

gemini-code-assist · 2025-10-28T15:12:31Z

packages/video_player/video_player_avfoundation/example/pubspec.yaml

  assets:
    - assets/flutter-mark-square-64.png
    - assets/Butterfly-209.mp4
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.


Per the repository style guide, the review agent should not comment about dependency_overrides sections in pubspec.yaml files that have a comment starting with: "FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE." ¹

Style Guide References

Footnotes

The review agent should not comment about dependency_overrides sections in pubspec.yaml files that have a comment starting with: "FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE." (link) ↩

- Added getAudioTracks() method supporting both HLS media selection and regular asset tracks - Added selectAudioTrack() method with support for both track selection mechanisms - Included comprehensive test coverage for audio track functionality with edge cases

- Update iOS minimum deployment target from 12.0 to 13.0 - Update macOS minimum deployment target from 10.14 to 10.15 - Add CocoaPods framework embedding build phases to Xcode projects

nateshmbhat · 2025-11-07T17:18:01Z

@LongCatIsLooong @tarrinneal could you please review this PR

nateshmbhat · 2025-11-19T14:37:24Z

any update on this ? 🙏🏻
@tarrinneal @LongCatIsLooong

nateshmbhat · 2025-11-24T06:00:05Z

🥲

tarrinneal · 2025-11-24T19:29:11Z

🥲

Sorry, I've been out as my wife is recovering from surgery. I'll try to get to this in the next couple days.

LongCatIsLooong · 2025-11-25T00:23:10Z

(just started reviewing this, I'll finish doing the review tomorrow, sorry for the delay I was working on a bugfix).

LongCatIsLooong

So far I've only looked at the objective-c implementation.
My biggest question: why is it required to drop down to lower-level AVAssetTrack stuff? I went to read a little about media selection group and my understanding is that it should be sufficient for most user-facing use cases. What are the use cases for the tracks information?

Additionally, track loading is lazy and asynchronous according to the documentation. I don't see logic that handles the asynchronism.

LongCatIsLooong · 2025-11-25T18:22:00Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+  // First, try to get tracks from media selection (for HLS streams)
+  AVMediaSelectionGroup *audioGroup =
+      [asset mediaSelectionGroupForMediaCharacteristic:AVMediaCharacteristicAudible];
+  if (audioGroup && audioGroup.options.count > 0) {


nit:

Suggested change

if (audioGroup && audioGroup.options.count > 0) {

if (audioGroup.options.count > 0) {

LongCatIsLooong · 2025-11-25T19:13:16Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+    NSMutableArray<FVPMediaSelectionAudioTrackData *> *mediaSelectionTracks =
+        [[NSMutableArray alloc] init];
+    AVMediaSelectionOption *currentSelection = nil;
+    if (@available(iOS 11.0, macOS 10.13, *)) {


I thought the plugin's lowest supported iOS version is 13.0 so we don't have to resort to the deprecated API?

LongCatIsLooong · 2025-11-25T19:18:44Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+      // Skip nil options
+      if (!option || [option isKindOfClass:[NSNull class]]) {
+        continue;


+1, why are we checking against NSNull or checking if the option is nil?

LongCatIsLooong · 2025-11-25T19:23:17Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+          [AVMetadataItem metadataItemsFromArray:option.commonMetadata
+                                         withKey:AVMetadataCommonKeyTitle
+                                        keySpace:AVMetadataKeySpaceCommon];
+      if (titleItems.count > 0 && titleItems.firstObject.stringValue) {


nit: is if isn't needed? firstObject returns nil if the array is empty according to documentation.

LongCatIsLooong · 2025-11-25T19:25:13Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+        commonMetadataTitle = titleItems.firstObject.stringValue;
+      }
+
+      BOOL isSelected = (currentSelection == option) || [currentSelection isEqual:option];


Isn't [currentSelection isEqual:option] sufficient?

LongCatIsLooong · 2025-11-25T21:17:26Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+
+        // Validate that we have a valid format description object
+        if (formatDescObj && [formatDescObj respondsToSelector:@selector(self)]) {
+          NSString *className = NSStringFromClass([formatDescObj class]);


Still, I don't understand the purpose of this if condition and code in the block. The implementation seems to be very hacky.

LongCatIsLooong · 2025-11-25T21:20:46Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+        }
+      } @catch (NSException *exception) {
+        // Handle any exceptions from format description parsing gracefully
+        // This ensures the method continues to work even with mock objects or invalid data


I don't think we should add test-aware / test-specific logic to production code.

LongCatIsLooong · 2025-11-25T21:25:02Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+                         trackId:(NSInteger)trackId
+                           error:(FlutterError *_Nullable __autoreleasing *_Nonnull)error {
+  AVPlayerItem *currentItem = _player.currentItem;
+  if (!currentItem || !currentItem.asset) {


Should this be an error? Attempting to select an audio track while the current item is nil violates the contract I think?

Actually, can currentItem be nil in FVVideoPlayer? The documentation says asset can't be nil: https://developer.apple.com/documentation/avfoundation/avplayeritem/asset

LongCatIsLooong · 2025-11-25T21:31:21Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+
+  AVAsset *asset = currentItem.asset;
+
+  // Check if this is a media selection track (for HLS streams)


My understanding is that media selection isn't only for HLS streams. Most container formats support them.

LongCatIsLooong · 2025-11-25T21:32:18Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+  // Check if this is a media selection track (for HLS streams)
+  if ([trackType isEqualToString:@"mediaSelection"]) {
+    // Validate that we have cached options and the trackId (index) is valid
+    if (_cachedAudioSelectionOptions && trackId >= 0 &&


What happens if there was no cache?

nateshmbhat requested review from LongCatIsLooong and hellohuanlin as code owners October 28, 2025 15:06

github-actions bot added platform-ios platform-macos p: video_player labels Oct 28, 2025

nateshmbhat mentioned this pull request Oct 28, 2025

[video_player] Adds audio track metadata fetching and audio track selection feature #9925

Open

11 tasks

gemini-code-assist bot reviewed Oct 28, 2025

View reviewed changes

stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Oct 28, 2025

nateshmbhat force-pushed the 28-oct-platform-avfoundation branch from 4784bd8 to 459e7f8 Compare November 7, 2025 16:32

nateshmbhat changed the title ~~feat(video): add audio track selection support for AVFoundation~~ feat(ios): add audio track selection support for AVFoundation Nov 7, 2025

chore(video_player): bump minimum OS versions for iOS and macOS

272ff1d

- Update iOS minimum deployment target from 12.0 to 13.0 - Update macOS minimum deployment target from 10.14 to 10.15 - Add CocoaPods framework embedding build phases to Xcode projects

nateshmbhat requested a review from tarrinneal as a code owner November 7, 2025 17:15

Merge branch 'main' into 28-oct-platform-avfoundation

6905f0a

This comment was marked as off-topic.

Sign in to view

nateshmbhat added 2 commits November 19, 2025 20:27

Merge branch 'main' into 28-oct-platform-avfoundation

b253fa4

Merge branch 'main' into 28-oct-platform-avfoundation

1bfefef

LongCatIsLooong reviewed Nov 25, 2025

View reviewed changes

	if (audioGroup && audioGroup.options.count > 0) {
	if (audioGroup.options.count > 0) {


		AVAsset *asset = currentItem.asset;

		// Check if this is a media selection track (for HLS streams)

feat(ios): add audio track selection support for AVFoundation #10313

Are you sure you want to change the base?

feat(ios): add audio track selection support for AVFoundation #10313

Conversation

nateshmbhat commented Oct 28, 2025

Pre-Review Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

nateshmbhat commented Nov 7, 2025

Uh oh!

This comment was marked as off-topic.

nateshmbhat commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nateshmbhat commented Nov 24, 2025

Uh oh!

tarrinneal commented Nov 24, 2025

Uh oh!

LongCatIsLooong commented Nov 25, 2025

Uh oh!

LongCatIsLooong left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nateshmbhat commented Nov 19, 2025 •

edited

Loading

LongCatIsLooong left a comment •

edited

Loading