-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[url_launcher] Remove unused dartHostTestHandler #10324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[url_launcher] Remove unused dartHostTestHandler #10324
Conversation
`url_launcher_windows` was setting a `dartHostTestHandler` in its Pigeon config file, but it was not actually using the test generator. Part of flutter/flutter#159886
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the dartHostTestHandler parameter from the @HostApi annotation in packages/url_launcher/url_launcher_windows/pigeons/messages.dart. This change removes an unused configuration for test handler generation, which is a good cleanup. The change is correct and I have no further comments.
|
CHANGELOG/version overrides: This change is a no-op; this parameter is only used to configure a generator that's not used (since |
|
test-exempt: removing code |
flutter/packages@4cec230...7063d75 2025-11-11 31859944+LongCatIsLooong@users.noreply.github.com [video_player_avfoundation] removes unnecessary duration and size check before sending the initialized event (flutter/packages#9534) 2025-11-11 magder@google.com Update Android package CODEOWNERS (flutter/packages#10386) 2025-11-11 stuartmorgan@google.com [url_launcher] Remove unused dartHostTestHandler (flutter/packages#10324) 2025-11-11 stuartmorgan@google.com [path_provider] Remove use of Pigeon's Dart test generator (flutter/packages#10323) 2025-11-11 stuartmorgan@google.com [image_picker] Remove use of Pigeon's Dart test generator (flutter/packages#10320) 2025-11-11 stuartmorgan@google.com [shared_preferences] Remove use of Pigeon's Dart test generator (flutter/packages#10325) 2025-11-10 50643541+Mairramer@users.noreply.github.com [camera_android_camerax] Fixes crash with unsupported operation exception (flutter/packages#10342) 2025-11-10 stuartmorgan@google.com [file_selector] Remove unused web code (flutter/packages#10376) 2025-11-10 engine-flutter-autoroll@skia.org Manual roll Flutter from c5e809a to 31a8481 (9 revisions) (flutter/packages#10392) 2025-11-10 danferreiradev@gmail.com [file_selector] Add canCreateDirectories to FileDialogOptions (flutter/packages#10317) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#178296) flutter/packages@4cec230...7063d75 2025-11-11 31859944+LongCatIsLooong@users.noreply.github.com [video_player_avfoundation] removes unnecessary duration and size check before sending the initialized event (flutter/packages#9534) 2025-11-11 magder@google.com Update Android package CODEOWNERS (flutter/packages#10386) 2025-11-11 stuartmorgan@google.com [url_launcher] Remove unused dartHostTestHandler (flutter/packages#10324) 2025-11-11 stuartmorgan@google.com [path_provider] Remove use of Pigeon's Dart test generator (flutter/packages#10323) 2025-11-11 stuartmorgan@google.com [image_picker] Remove use of Pigeon's Dart test generator (flutter/packages#10320) 2025-11-11 stuartmorgan@google.com [shared_preferences] Remove use of Pigeon's Dart test generator (flutter/packages#10325) 2025-11-10 50643541+Mairramer@users.noreply.github.com [camera_android_camerax] Fixes crash with unsupported operation exception (flutter/packages#10342) 2025-11-10 stuartmorgan@google.com [file_selector] Remove unused web code (flutter/packages#10376) 2025-11-10 engine-flutter-autoroll@skia.org Manual roll Flutter from c5e809a to 31a8481 (9 revisions) (flutter/packages#10392) 2025-11-10 danferreiradev@gmail.com [file_selector] Add canCreateDirectories to FileDialogOptions (flutter/packages#10317) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
url_launcher_windowswas setting adartHostTestHandlerin its Pigeon config file, but it was not actually using the test generator.Part of flutter/flutter#159886
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3