Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

url_launcher_windows was setting a dartHostTestHandler in its Pigeon config file, but it was not actually using the test generator.

Part of flutter/flutter#159886

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

`url_launcher_windows` was setting a `dartHostTestHandler` in its Pigeon
config file, but it was not actually using the test generator.

Part of flutter/flutter#159886
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 29, 2025
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the dartHostTestHandler parameter from the @HostApi annotation in packages/url_launcher/url_launcher_windows/pigeons/messages.dart. This change removes an unused configuration for test handler generation, which is a good cleanup. The change is correct and I have no further comments.

@stuartmorgan-g
Copy link
Collaborator Author

CHANGELOG/version overrides: This change is a no-op; this parameter is only used to configure a generator that's not used (since dartTestOut is not set).

@stuartmorgan-g
Copy link
Collaborator Author

test-exempt: removing code

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 11, 2025
@auto-submit auto-submit bot merged commit 86e4ab0 into flutter:main Nov 11, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 11, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 11, 2025
flutter/packages@4cec230...7063d75

2025-11-11 31859944+LongCatIsLooong@users.noreply.github.com
[video_player_avfoundation] removes unnecessary duration and size check
before sending the initialized event (flutter/packages#9534)
2025-11-11 magder@google.com Update Android package CODEOWNERS
(flutter/packages#10386)
2025-11-11 stuartmorgan@google.com [url_launcher] Remove unused
dartHostTestHandler (flutter/packages#10324)
2025-11-11 stuartmorgan@google.com [path_provider] Remove use of
Pigeon's Dart test generator (flutter/packages#10323)
2025-11-11 stuartmorgan@google.com [image_picker] Remove use of Pigeon's
Dart test generator (flutter/packages#10320)
2025-11-11 stuartmorgan@google.com [shared_preferences] Remove use of
Pigeon's Dart test generator (flutter/packages#10325)
2025-11-10 50643541+Mairramer@users.noreply.github.com
[camera_android_camerax] Fixes crash with unsupported operation
exception (flutter/packages#10342)
2025-11-10 stuartmorgan@google.com [file_selector] Remove unused web
code (flutter/packages#10376)
2025-11-10 engine-flutter-autoroll@skia.org Manual roll Flutter from
c5e809a to 31a8481 (9 revisions) (flutter/packages#10392)
2025-11-10 danferreiradev@gmail.com [file_selector] Add
canCreateDirectories to FileDialogOptions (flutter/packages#10317)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja pushed a commit to IvoneDjaja/flutter that referenced this pull request Nov 22, 2025
…er#178296)

flutter/packages@4cec230...7063d75

2025-11-11 31859944+LongCatIsLooong@users.noreply.github.com
[video_player_avfoundation] removes unnecessary duration and size check
before sending the initialized event (flutter/packages#9534)
2025-11-11 magder@google.com Update Android package CODEOWNERS
(flutter/packages#10386)
2025-11-11 stuartmorgan@google.com [url_launcher] Remove unused
dartHostTestHandler (flutter/packages#10324)
2025-11-11 stuartmorgan@google.com [path_provider] Remove use of
Pigeon's Dart test generator (flutter/packages#10323)
2025-11-11 stuartmorgan@google.com [image_picker] Remove use of Pigeon's
Dart test generator (flutter/packages#10320)
2025-11-11 stuartmorgan@google.com [shared_preferences] Remove use of
Pigeon's Dart test generator (flutter/packages#10325)
2025-11-10 50643541+Mairramer@users.noreply.github.com
[camera_android_camerax] Fixes crash with unsupported operation
exception (flutter/packages#10342)
2025-11-10 stuartmorgan@google.com [file_selector] Remove unused web
code (flutter/packages#10376)
2025-11-10 engine-flutter-autoroll@skia.org Manual roll Flutter from
c5e809a to 31a8481 (9 revisions) (flutter/packages#10392)
2025-11-10 danferreiradev@gmail.com [file_selector] Add
canCreateDirectories to FileDialogOptions (flutter/packages#10317)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: url_launcher platform-windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants