Skip to content

Conversation

@zshaian
Copy link
Contributor

@zshaian zshaian commented May 8, 2025

Pull Request Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • The contrast between the background and the text on hover to back-to-top button is low, and the text is hard to see
  • The Alignment of text in the channel tag looks odd
  • The text header in the project description section looks too compressed
  • In the resources and in portfolio category some of the section text can't be seen because the color of their text remain text-color-gray-800 when the theme is dark

What is the new behavior?

  • The text is now darker to balance the contrast between the icon and the background of the button
  • Text is now align in center
  • Increase the line height of the text header in the project-description section
  • make the text-color-gray-800 have a more lighter color when the theme is dark

Does this introduce a breaking change?

[ ] Yes

  • No

@vercel
Copy link

vercel bot commented May 8, 2025

@zshaian is attempting to deploy a commit to the Niko Hoffrén's Team Team on Vercel.

A member of the Team first needs to authorize it.

@zshaian zshaian changed the title Enchancement/components chore: make some minor adjustments on some of the components May 8, 2025
@vercel
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fork-commit-merge-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 4:59am

Copy link
Member

@nikohoffren nikohoffren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nikohoffren nikohoffren merged commit 7bcb748 into fork-commit-merge:main May 9, 2025
5 checks passed
@nikohoffren
Copy link
Member

Pull request merged

This is an automated message from Fork, Commit, Merge - web [BOT].

Thank you for your contribution! Your pull request has been merged and your name has been added to the List of Contributors in README.md.
Please leave a star if you enjoyed working on this project.

What's next?

If you're looking for more ways to contribute, I invite you to check out my other projects here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants