-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add privacy specific taxonomy #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
… privacy fields where relevant
capachino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, a few more things before merging:
- I believe you'll also need to update
commands/security/analyze-github-pr.tomlso maybe after everyone LGTM the changes toanalyze.toml - Should update the repo README.md to reflect these new capabilities.
As part of #47, this PR helps ensure P0 CUJ-1 (log data leak ID and removal) and P0 CUJ-2 (ID sensitive flow to 3P) is addressed in the
security:analyzecommandThis also helps cover more privacy specific features via outputting a simple datamap with source and sinks that the end of the analysis
Pending more test cases, this is an example of what a run would look like with a small set of tests: https://screenshot.googleplex.com/8nuFzxWcS5V2X6b (computer settings won't let me paste or upload an image to GH for some reason)
In short, this mainly adds: