Test and fix for tensors in marching cubes when Pytorch #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leguark
force-pushed
the
marching-cubes-fix
branch
from
ca7f095 to
f19b02c
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Leguark
approved these changes
Nov 12, 2025
Member
Leguark
left a comment
Leguark
left a comment
There was a problem hiding this comment.
Thanks Nils. Sorry for the delay, I am changing the computer where we are running the tests and I had to update some paths
I just changed the line the AI suggested (I am pretty sure it was right).
Member
|
@NilsChudalla this is ready to press the big green button |
Member
Author
|
But I am nervous, because it is my first PR to gempy 😜 no, I actually got this error for every merge option: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Pytorch, Marching cubes algorithm was unable to resolve due to tensor object, where ndarrays should be. This issue occured for scalarfields and in some cases for masks, too. This PR contains the test for pytorch (copied after the existing MC test) and the fix.
Relates to
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).