Fix undefined 'id' property error #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential runtime error by adding optional chaining to safely access the session property. The change prevents a crash when session.session is undefined.
Key changes:
- Added optional chaining operator (
?.) tosession.session.idaccess
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Still haven't nailed down a scenario for this as it defies the types, but I know folks have run into it, so this is fair. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in certain situations, such as using subdomains with better auth, that
authClient.useSession()returns undefined data. This then causes anundefined id on undefinederror here. This fixes the issue and makes this work again.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.