Add warning test to detect duplicate table names in schema (#1) #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Fix redundant ratelimit schema declaration Co-authored-by: bharxhav <70275374+bharxhav@users.noreply.github.com> * Add comment documenting the duplicate rateLimit issue Co-authored-by: bharxhav <70275374+bharxhav@users.noreply.github.com> * Revert manual schema fix and add warning test for duplicate table names Co-authored-by: bharxhav <70275374+bharxhav@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bharxhav <70275374+bharxhav@users.noreply.github.com>
Collaborator
|
Thanks for this! I love a good test, but this really is a core Better Auth issue, I don't want to use tests here to ensure against upstream bugs, as there's no good logical limit to that. It looks like the issue in source is here: https://github.com/better-auth/better-auth/blob/d90e1f2eb75b1cafb1211a03e188345d53e53854/packages/better-auth/src/adapters/adapter-factory/index.ts#L1002-L1003 |
Collaborator
|
I will go ahead and drop the redundant definition at least, though. Thanks again for calling it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asserts future issues before release, basis: #162
Redundant table definition is being generated by better-auth/better-auth. To maintain single source of truth, no manual change was done to fix the actual issue.
A test is being proposed to catch bad table nomenclature.