Skip to content

Conversation

@ferntheplant
Copy link

Full context:

  1. I monkey patched @convex-dev/workflow to not patch non-deterministic globals so I could use workflows with convex-test
  2. step.runAction and other workflow methods worked fine if they did not throw
  3. If the action did throw, however, I got weird errors like Error when running scheduled function complete:complete Error: Could not find module for: "complete" that made me believe the test instance was not correctly catching the error and so the execution runtime was getting messed up
  4. tried this dirty fix and it seems to work fine now - though the logging is a little excessive

I don't think this is ideal to merge as is but wanted to raise the bug and potential fix path. Ideally we'd apply a similar try/catch to mutationFromPath as well. What is the general policy for logging in this situation since this creates quite cluttered logs with retries?


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant