Skip to content

fix: broken capture list failure mechanism #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

fix: broken capture list failure mechanism #878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions src/components/browser/BrowserWindow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,16 +1174,31 @@ export const BrowserWindow = () => {
undefined,
false
);

if (pendingNotification) {
notify(pendingNotification.type, pendingNotification.message);
setPendingNotification(null);
}
} else {
console.warn(`Failed to extract any fields from list selector: ${listSelector}`);

setListSelector(null);
setFields({});
setCachedListSelector(null);
setCachedChildSelectors([]);
setCurrentListId(null);
setInitialAutoFieldIds(new Set());
setPendingNotification(null);

notify(
"error",
"The list you have selected is not valid. Please reselect it."
);
}
} catch (error) {
console.error("Error during child selector caching:", error);
} finally {
setIsCachingChildSelectors(false);

if (pendingNotification) {
notify(pendingNotification.type, pendingNotification.message);
setPendingNotification(null);
}
}
}, 100);
} else {
Expand Down Expand Up @@ -1710,16 +1725,17 @@ export const BrowserWindow = () => {
let cleanedSelector = highlighterData.selector;

setListSelector(cleanedSelector);
notify(
`info`,
t(
setPendingNotification({
type: `info`,
message: t(
"browser_window.attribute_modal.notifications.list_select_success",
{
count: highlighterData.groupInfo.groupSize,
}
) ||
`Selected group with ${highlighterData.groupInfo.groupSize} similar elements`
);
`Selected group with ${highlighterData.groupInfo.groupSize} similar elements`,
count: highlighterData.groupInfo.groupSize,
});
setCurrentListId(Date.now());
setFields({});

Expand Down