Skip to content

feat(init): Log why a properties file was not loaded #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2025
+25 −3
Merged

feat(init): Log why a properties file was not loaded #4879

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4ed940
Log why a properties file was not loaded
adinauer Nov 7, 2025
274b6df
Format code
getsentry-bot Nov 7, 2025
b572714
Merge branch 'main' into feat/better-logging-if-properties-file-not-l…
adinauer Nov 10, 2025
8b95cbe
fix(config): Trim whitespace on properties path (#4880)
adinauer Nov 10, 2025
0f3ff3c
changelog
adinauer Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger log
properties.load(is);
return properties;
}
} else if (!f.isFile()) {
logger.log(
SentryLevel.ERROR,
"Failed to load Sentry configuration since it is not a file or does not exist: %s",
filePath);
} else if (!f.canRead()) {
logger.log(
SentryLevel.ERROR,
"Failed to load Sentry configuration since it is not readable: %s",
filePath);
Copy link

@cursor cursor bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Whitespace Path Mismatch

The error messages log the original filePath which may contain whitespace, but the actual file check uses filePath.trim(). This creates confusing logs where the displayed path doesn't match the path that was actually checked, making debugging difficult when paths have leading or trailing whitespace.

Fix in Cursor Fix in Web

}
} catch (IOException e) {
logger.log(
Expand Down
Loading