Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/update-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ on:

jobs:
cocoa:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-cocoa.sh
name: Cocoa SDK
secrets:
api-token: ${{ secrets.CI_DEPLOY_KEY }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: cocoa and java jobs use updater@v3 (composite action) with v2 reusable workflow syntax, preventing execution.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The cocoa and java jobs in .github/workflows/update-deps.yml are configured to use getsentry/github-workflows/updater@v3, which is a composite action. However, these jobs retain the v2 reusable workflow syntax, where uses: is specified at the job level. Composite actions require runs-on at the job level and uses: within a steps array. This structural incompatibility will prevent the cocoa and java jobs from executing, leading to CI failures.

💡 Suggested Fix

Modify cocoa and java jobs to use composite action syntax: add runs-on: ubuntu-latest at the job level and move uses: getsentry/github-workflows/updater@v3 into a steps array.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/update-deps.yml#L14-L19

Potential issue: The `cocoa` and `java` jobs in `.github/workflows/update-deps.yml` are
configured to use `getsentry/github-workflows/updater@v3`, which is a composite action.
However, these jobs retain the `v2` reusable workflow syntax, where `uses:` is specified
at the job level. Composite actions require `runs-on` at the job level and `uses:`
within a `steps` array. This structural incompatibility will prevent the `cocoa` and
`java` jobs from executing, leading to CI failures.

Did we get this right? 👍 / 👎 to inform future reviews.


java:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-java.sh
name: Java SDK
Expand Down