-
Notifications
You must be signed in to change notification settings - Fork 567
tests(huggingface): Avoid None version
#5083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alexander-alderman-webb
wants to merge
17
commits into
master
Choose a base branch
from
webb/run-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+74
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
None version
Comment on lines
+1763
to
+1766
| def _replace_hyphens_dots_and_underscores_with_dashes(name): | ||
| # type: (str) -> str | ||
| # https://peps.python.org/pep-0503/#normalized-names | ||
| return re.sub(r"[-_.]+", "-", name) |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I changed _normalize_module_name, but I'm worried that could change the identifiers in the list set by the ModulesIntegration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normalize package identifiers according to https://peps.python.org/pep-0503/#normalized-names when getting a package version.
Fixes the
huggingface-hubtest suite, which fails because the identifier returned byimportlib.metadatachanged. To confirmand then run
in the interpreter, you should have a
huggingface-hubin the list. If you instead install "huggingface-hub==1.1.2" and follow the steps above, you instead seehuggingface_hub.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)