Skip to content

Conversation

@gggritso
Copy link
Member

@gggritso gggritso commented Nov 7, 2025

This component has a bunch of use, including via GlobalDrawer but no Scraps story! I'm about to do some work with it (supporting deferred rendering, and overspring padding) and it's a lot easier to do that in Scraps.

This felt like the right time to lift this component up in the folder hierarchy, too, and convert to a named export.

Does this component need any API changes or improvements before it's "official"? e.g., collapsed is awkward, passing className IMO is awkward, and so on

All other feedback welcome

@gggritso gggritso requested review from a team as code owners November 7, 2025 22:01
@linear
Copy link

linear bot commented Nov 7, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 7, 2025
@JonasBa
Copy link
Member

JonasBa commented Nov 8, 2025

Does this component need any API changes or improvements before it's "official"? e.g., collapsed is awkward, passing className IMO is awkward, and so on

Definitely need some TLC, but I think it's a good start. Since I know you've worked on the transition config, wdyt about just making that sprint transition be the default? I don't even think we need or want to allow people to change that in this instance

@gggritso
Copy link
Member Author

@JonasBa I would love to make the spring config the default, but I can't just yet! Spring can't be used in Dashboard right now (it's overridden there) because the overspring there looks very bad, because it's over a dark background. I'm going to fix the overspring soon, and then I can remove the customizable transition properties here 🙏🏻

@gggritso gggritso merged commit a9bf088 into master Nov 13, 2025
47 checks passed
@gggritso gggritso deleted the georgegritsouk/de-539-add-scraps-entry-for-slideoverpanel branch November 13, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants