add version to all shared object files #17091
Open
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furrysalamander
requested review from
0cc4m,
ggerganov,
lhez,
max-krasnyansky,
ngxson,
reeselevine,
rgerganov,
slaren and
taronaeo
as code owners
github-actions
bot
added
Nvidia GPU
slaren
reviewed
Nov 8, 2025
ggml/src/ggml-blas/CMakeLists.txt
Outdated
Comment on lines
18
to
21
| set_target_properties(ggml-blas PROPERTIES | ||
| VERSION ${GGML_VERSION} | ||
| SOVERSION ${GGML_VERSION_MAJOR} | ||
| ) |
Member
There was a problem hiding this comment.
I would prefer this in ggml_add_backend_library, rather than duplicating it for every backend.
Author
There was a problem hiding this comment.
Good call, I'll get that fixed on Monday.
When compiling llama.cpp in Yocto, it fails QA checks because the generated so files aren't versioned. This applies a version to all generated so files, allowing the package to build without errors.
furrysalamander
force-pushed
the
master
branch
from
ec3d4ce to
2719f80
Compare
0cc4m
removed request for
0cc4m,
ggerganov,
lhez,
max-krasnyansky,
ngxson,
reeselevine,
rgerganov and
taronaeo
CISC
removed
Nvidia GPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a Yocto recipe for llama.cpp, I got some QA errors because the so files don't have a version set. This is an easy enough fix, you just have to specify one in Cmake.
I've done my best to set these with what I understand are appropriate values, but if I'm pulling in inappropriate variables for any of these, by all means let's fix them. The mtmd stuff in particular seemed a bit ambiguous, but even though it's a "subproject" I imagine the desire (for now) is to still release (and version) it together with llama.cpp as a whole?