-
Notifications
You must be signed in to change notification settings - Fork 13.6k
mtmd: fix patch_size initialized to random value in audio models #17128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just have default values in clip_hparams though?
Either way is possible, but I think it's better to avoid communicating |
What about at least initializing it to |
|
Initializing to 0 breaks the current audio model implementation. It was found because my system initialized it as 0 already resulting in audio models failing to launch at random moments. |
I meant in |
yes and even better, I think there should be default value for other hparams too (added in 4ac2c20) This should prevent forgetting to initialize one of the params in general. |
|
also there are multiple GGML_ASSERT scattered throughout the code that can trip if patch size is an unexpected value even if unused. but this approach should work. |
Fix #17125
Tests are OK: