Skip to content

Conversation

@Wiktorro
Copy link

@Wiktorro Wiktorro commented Nov 13, 2025

Git provided completion for long options but not the short ones

Thanks for taking the time to contribute to Git!

Those seeking to contribute to the Git for Windows fork should see
http://gitforwindows.org/#contribute on how to contribute Windows specific
enhancements.

If your contribution is for the core Git functions and documentation
please be aware that the Git community does not use the github.com issues
or pull request mechanism for their contributions.

Instead, we use the Git mailing list (git@vger.kernel.org) for code and
documentation submissions, code reviews, and bug reports. The
mailing list is plain text only (anything with HTML is sent directly
to the spam folder).

Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.

For a single-commit pull request, please leave the pull request description
empty
: your commit message itself should describe your changes.

Please read the "guidelines for contributing" linked above!

Signed-off-by: Wiktor Mis mwiktor023@gmail.com

Git provided completion for long options but not the short ones

Signed-off-by: Wiktorro <48845694+Wiktorro@users.noreply.github.com>
@Wiktorro
Copy link
Author

Wiktorro commented Nov 13, 2025

git version 2.51.2.windows.1 from https://github.com/git-for-windows/git
Modification tested, maintained earlier functionality, upon completion request with multiple TABs behaves as presented
gitCompletionMyChange

@dscho
Copy link
Member

dscho commented Nov 13, 2025

@Wiktorro thank you for this contribution. It is, however, not specific to Windows, so I wonder whether you want to contribute it directly to the Git project instead?

In any case, this patch targets the core Git code and is therefore subject to Git's rules. Therefore, could you please use your real name in the Signed-off-by line and in your author information? The Git project insists on that. You can fix it by configuring user.name, then git commit --amend --reset-author --signoff (deleting the superseded Signed-off-by line), and force-pushing.

@Wiktorro
Copy link
Author

@Wiktorro thank you for this contribution. It is, however, not specific to Windows, so I wonder whether you want to contribute it directly to the Git project instead?

In any case, this patch targets the core Git code and is therefore subject to Git's rules. Therefore, could you please use your real name in the Signed-off-by line and in your author information? The Git project insists on that. You can fix it by configuring user.name, then git commit --amend --reset-author --signoff (deleting the superseded Signed-off-by line), and force-pushing.

Oh yes, it's much better to handle it from git source first, so I will address this case there before I try progressing with this PR, Thanks.
About sign off infos, I will handle them in free moment as well - unfortunately I needed recently to migrate my work environment so I did commit via browser, copying my change from editor. Will take a moment to bring order to my setup...

Marking this as draft, just to avoid wasting attention, thanks.for immediate response!

@Wiktorro Wiktorro marked this pull request as draft November 13, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants