wincred: Avoid memory corruption #2005
Conversation
|
There are issues in commit 72938e8: |
`wcsncpy_s()` wants to write the terminating null character so we need to allocate one more space for it in the target memory block. This should fix crashes when trying to read passwords. When this happened, the password/token wouldn't print out and Git would therefore ask for a new password every time. Signed-off-by: David Macek <david.macek.0@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
wincred-Avoid-memory-corruption-5856-
branch
from
72938e8 to
4fdcccc
Compare
|
/submit |
|
Submitted as pull.2005.git.1763411984773.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
This patch series was integrated into seen via git@2f886f0. |
|
This patch series was integrated into seen via git@7d67e77. |
|
This branch is now known as |
|
This patch series was integrated into seen via git@6a1b73d. |
|
This patch series was integrated into seen via git@37b073b. |
|
This patch series was integrated into next via git@4c43c53. |
|
There was a status update in the "New Topics" section about the branch Under-allocation fix. Will merge to 'master'. source: <pull.2005.git.1763411984773.gitgitgadget@gmail.com> |
|
This patch series was integrated into seen via git@e6f3233. |
2 participants
This patch wants to be upstreamed...