-
Notifications
You must be signed in to change notification settings - Fork 686
feat(runner-binaries-syncer): add s3_tags variable for additional S3 bucket tagging #4832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damianrekosz
wants to merge
4
commits into
github-aws-runners:main
Choose a base branch
from
damianrekosz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -25,6 +25,7 @@ module "runner_binaries" { | |||||
| state_event_rule_binaries_syncer = var.state_event_rule_binaries_syncer | ||||||
|
|
||||||
| server_side_encryption_configuration = var.runner_binaries_s3_sse_configuration | ||||||
| s3_tags = local.s3_tags[each.key] | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| s3_versioning = var.runner_binaries_s3_versioning | ||||||
|
|
||||||
| role_path = var.role_path | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,6 +114,7 @@ variable "multi_runner_config" { | |
| cloudwatch_config = optional(string, null) | ||
| userdata_pre_install = optional(string, "") | ||
| userdata_post_install = optional(string, "") | ||
| runner_binaries_s3_tags = optional(map(string), {}) | ||
| runner_hook_job_started = optional(string, "") | ||
| runner_hook_job_completed = optional(string, "") | ||
| runner_ec2_tags = optional(map(string), {}) | ||
|
|
@@ -222,6 +223,7 @@ variable "multi_runner_config" { | |
| cloudwatch_config: "(optional) Replaces the module default cloudwatch log config. See https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch-Agent-Configuration-File-Details.html for details." | ||
| userdata_pre_install: "Script to be ran before the GitHub Actions runner is installed on the EC2 instances" | ||
| userdata_post_install: "Script to be ran after the GitHub Actions runner is installed on the EC2 instances" | ||
| runner_binaries_s3_tags: "Map of tags that will be added to the S3 bucket used by the runner binaries syncer for this runner configuration. Note these are additional tags to the default tags." | ||
| runner_hook_job_started: "Script to be ran in the runner environment at the beginning of every job" | ||
| runner_hook_job_completed: "Script to be ran in the runner environment at the end of every job" | ||
| runner_ec2_tags: "Map of tags that will be added to the launch template instance tag specifications." | ||
|
|
@@ -404,6 +406,12 @@ variable "runner_binaries_s3_sse_configuration" { | |
| } | ||
| } | ||
|
|
||
| variable "runner_binaries_s3_tags" { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This variable is ok, lets remove the one on runner config lvel. |
||
| description = "Map of tags that will be added to the S3 bucket. Note these are additional tags to the default tags." | ||
| type = map(string) | ||
| default = {} | ||
| } | ||
|
|
||
| variable "runner_binaries_s3_versioning" { | ||
| description = "Status of S3 versioning for runner-binaries S3 bucket. Once set to Enabled the change cannot be reverted via Terraform!" | ||
| type = string | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this local for
s3_tagsis not needed. The multi runner crates a bucket per github dist. Which means not a bucket er multi runner. So would simple pass the s3_tags down to the module. And no cmplext merge.