Skip to content

Conversation

@UlisesGascon
Copy link
Contributor

@UlisesGascon UlisesGascon commented Jul 9, 2025

Copilot AI review requested due to automatic review settings July 9, 2025 14:28
@UlisesGascon UlisesGascon requested a review from a team as a code owner July 9, 2025 14:28

Using open source dependencies can speed up development, but each package includes a license that defines how it can be used, modified, or distributed. Some licenses are permissive, while others (like AGPL or SSPL) impose restrictions that may not be compatible with your project's goals or your users' needs.

Imagine this: You add a powerful library to your project, unaware that it uses a restrictive license. Later, a company wants to adopt your project but raises concerns about license compliance. The result? You lose adoption, need to refactor code, and your project’s reputation takes a hit.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeffrey-Luszcz feel free to suggest a better example for the mixed-license scenario in the license section. You probably have a much stronger one than mine 🙏

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yu7

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 9, 2025
Copy link

@xcorail xcorail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions!
I will let @Jeffrey-Luszcz weigh in on the licensing stuff, and I made a suggestion for the IR plan section, but I like the rest.

@jmeridth
Copy link
Member

@UlisesGascon I see @xcorail has some suggestions above. Can you take a look and discuss/accomodate? I've pinged @Jeffrey-Luszcz and he'll be taking a look when he can. Thank you for the contribution.


Imagine this: You add a powerful library to your project, unaware that it uses a restrictive license. Later, a company wants to adopt your project but raises concerns about license compliance. The result? You lose adoption, need to refactor code, and your project's reputation takes a hit.

To avoid these pitfalls, consider including automated license checks as part of your development workflow. These checks can help identify incompatible licenses early in the process, preventing problematic dependencies from being introduced into your project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an existing auto license check tool that we could link users to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on this, but we could point readers to a couple of options but not easy to adopt (IMO).

For example, FOSSA is a commercial tool that provides automated license-compliance scanning, and there’s also the OSS Review Toolkit (ORT), an open-source option that includes a license scanner: https://oss-review-toolkit.org/ort/docs/tools/scanner/

Most of the scanners I use personally are specific to npm universe 🤔.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for npm? npmjs.com/licensee

@velkovacece50-collab

This comment has been minimized.

@piraporn

This comment was marked as spam.

@jmeridth jmeridth marked this pull request as draft October 17, 2025 16:15
@jmeridth
Copy link
Member

Converting to draft until author re-engages.

@UlisesGascon
Copy link
Contributor Author

I plan to rework on this PR next week once I am back from vacations

kerolosmagdy103-alt

This comment was marked as spam.

@UlisesGascon UlisesGascon marked this pull request as ready for review November 13, 2025 15:23
@UlisesGascon UlisesGascon requested a review from xcorail November 13, 2025 15:23
Co-authored-by: Xavier RENE-CORAIL <xcorail@github.com>
Co-authored-by: Xavier RENE-CORAIL <xcorail@github.com>
Copy link

@xcorail xcorail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me - I just suggested a typo fix.
I will approve the PR, but I defer to @Jeffrey-Luszcz for the licensing part

Thanks @UlisesGascon for these additions!

Co-authored-by: Xavier RENE-CORAIL <xcorail@github.com>
A new contributor gets write access to the main branch and accidentally pushes changes that have not been tested. A dire security flaw is then uncovered, courtesy of the latest changes. To prevent such issues, branch protection rules ensure that changes cannot be pushed or merged into important branches without first undergoing reviews and passing specified status checks. You're safer and better off with this extra measure in place, guaranteeing top-notch quality every time.

## Set up an intake mechanism for vulnerability reporting
## Make it easy (and safe) to report security issues

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x217ee1740bc4ba7d6b708b79094b675783201402

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x217ee1740bc4ba7d6b708b79094b675783201402

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x217ee1740bc4ba7d6b708b79094b675783201402


A new contributor gets write access to the main branch and accidentally pushes changes that have not been tested. A dire security flaw is then uncovered, courtesy of the latest changes. To prevent such issues, branch protection rules ensure that changes cannot be pushed or merged into important branches without first undergoing reviews and passing specified status checks. You're safer and better off with this extra measure in place, guaranteeing top-notch quality every time.

## Set up an intake mechanism for vulnerability reporting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x217ee1740bc4ba7d6b708b79094b675783201402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.