-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
feat(commit_comment): Add inline comments on commit diffs #35896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ced02fa to
79eb8ac
Compare
|
It also have the same problem as #32257 when the comments in the hidden lines. |
| // CommitComment represents a comment on a specific line in a commit diff | ||
| type CommitComment struct { | ||
| ID int64 `xorm:"pk autoincr"` | ||
| RepoID int64 `xorm:"INDEX"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can have a reply_id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only one or two fields, the table's design overall doesn't seem right. I have explained in discord.
One more thing: "Add inline comments on commits #4898" requests the feature for "commits", but not for "commit diffs" By the way, I don't quite understand why this feature is that important or how end users can really use it, also quote my discord question:
And many voices in #4898 are talking about "comment on files directly (for student, education #4898 (comment))", not really "per commit". Overall I don't see real use cases for such "commit level comments" |
Resolves #4898
/claim #4898
Added ability to add inline comments on commit diffs. Using new
commit_commenttable and re-using the existing comment template and other existing functionality eg. Attachments & reactions.Demo:
Screen.Recording.2025-11-07.at.17.44.35.mov